-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add XSLT transformation recipe #3606
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Impressive work already; thanks for getting this started! Curious to hear what you intend to use if for. I've gone through for a first round of review comments, let me know how you feel about what I've raised so far!
rewrite-maven/src/main/java/org/openrewrite/maven/ChangePluginConfiguration.java
Outdated
Show resolved
Hide resolved
rewrite-maven/src/main/java/org/openrewrite/maven/ChangePluginConfiguration.java
Outdated
Show resolved
Hide resolved
rewrite-xml/src/main/java/org/openrewrite/xml/XsltTransformation.java
Outdated
Show resolved
Hide resolved
rewrite-xml/src/main/java/org/openrewrite/xml/XsltTransformation.java
Outdated
Show resolved
Hide resolved
rewrite-xml/src/main/java/org/openrewrite/xml/XsltTransformationVisitor.java
Outdated
Show resolved
Hide resolved
rewrite-xml/src/main/java/org/openrewrite/xml/XsltTransformationVisitor.java
Outdated
Show resolved
Hide resolved
rewrite-xml/src/main/java/org/openrewrite/xml/XsltTransformationVisitor.java
Outdated
Show resolved
Hide resolved
rewrite-xml/src/main/java/org/openrewrite/xml/XsltTransformationVisitor.java
Outdated
Show resolved
Hide resolved
The original idea came from upgrading jaxb2-maven-plugin version 1.x (javax.xml) to 3.x (jakarta.xml). |
…Configuration.java Co-authored-by: Tim te Beek <timtebeek@gmail.com>
…Configuration.java Co-authored-by: Tim te Beek <timtebeek@gmail.com>
…on.java Co-authored-by: Tim te Beek <timtebeek@gmail.com>
…onVisitor.java Co-authored-by: Tim te Beek <timtebeek@gmail.com>
…onVisitor.java Co-authored-by: Tim te Beek <timtebeek@gmail.com>
…onVisitor.java Co-authored-by: Tim te Beek <timtebeek@gmail.com>
…onVisitor.java Co-authored-by: Tim te Beek <timtebeek@gmail.com>
rewrite-maven/src/main/java/org/openrewrite/maven/ChangePluginConfiguration.java
Outdated
Show resolved
Hide resolved
rewrite-xml/src/main/java/org/openrewrite/xml/XsltTransformation.java
Outdated
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Added some minor polishing but otherwise good to go if you ask me. I'll leave a little room for further feedback before I merge, but will merge before the next release.
And thank for the kind contribution, explaining your intended use, and patience in seeing this through.
What's changed?
Allow ChangePluginConfiguration to perform XSLT transformation on plugin configuration. Also, added a new recipe for arbitrary XSLT transformations.
What's your motivation?
Perform XSLT transformations on XML files and on Maven plugin configuration.
Anything in particular you'd like reviewers to focus on?
No
Anyone you would like to review specifically?
No
Have you considered any alternatives or workarounds?
FindAndReplace works for simple refactoring, but this allow more complex scenarios.
Any additional context
No
Checklist
./gradlew licenseFormat