Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe to print out git provenance #2640

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Recipe to print out git provenance #2640

merged 1 commit into from
Jan 13, 2023

Conversation

kmccarp
Copy link
Contributor

@kmccarp kmccarp commented Jan 12, 2023

No description provided.

@sambsnyd sambsnyd merged commit bb33750 into openrewrite:main Jan 13, 2023
sambsnyd pushed a commit that referenced this pull request Jan 14, 2023
@knutwannheden
Copy link
Contributor

@kmccarp Locally the test is failing for me when it attempts to serialize and then deserialize the recipe again using Jackson, because the recipe in DataTable is null. Can you reproduce this? I suspect the ShowGitProvenance#table field should be annotated as @JsonIgnore.

@knutwannheden
Copy link
Contributor

Nevermind, looks like @jkschneider already fixed it: c2eed41

@kmccarp
Copy link
Contributor Author

kmccarp commented Jan 16, 2023

Nevermind, looks like @jkschneider already fixed it: c2eed41

Yep, data tables were added after this PR.

@sambsnyd sambsnyd added this to the 7.35.0 milestone Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants