Create RemoveRepository recipe #2617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The corresponding test suite only contains tests that uses the id/url parameters (not repoName, layout, snapshotsEnabled, etc., which will be added soon!).
JLLeitschuh
reviewed
Jan 12, 2023
Comment on lines
+97
to
+98
| if (id == null && (isReleasesEqual(repo) && isSnapshotsEqual(repo)) && | ||
| url.equals(repo.getChildValue("url").orElse(null))) { |
There was a problem hiding this comment.
@jkschneider what if I want to match something like the regular expression: http[s]+://maven.glassfish.org/?.*
Is there a better way we could do matching here that allows for more generic removals like this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The corresponding test suite currently only contains tests that uses the id/url parameters (not repoName, layout, snapshotsEnabled, etc., which will be added soon!).