Skip to content

Commit

Permalink
SimpleTraitMatcher uses preVisit rather than visit
Browse files Browse the repository at this point in the history
  • Loading branch information
@jkschneider
jkschneider committed Jul 9, 2024
1 parent c489aa3 commit 1c11e1f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion rewrite-core/src/main/java/org/openrewrite/trait/SimpleTraitMatcher.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ public Stream<U> lower(Cursor cursor) {
public <P> TreeVisitor<? extends Tree, P> asVisitor(VisitFunction2<U, P> visitor) {
return new TreeVisitor<Tree, P>() {
@Override
public @Nullable Tree visit(@Nullable Tree tree, P p) {
public @Nullable Tree preVisit(Tree tree, P p) {
U u = test(getCursor());
return u != null ?
visitor.visit(u, p) :

This comment has been minimized.

Sign in to view

Copy link
@knutwannheden

knutwannheden Jul 9, 2024

Contributor

@jkschneider Wouldn't it make sense for the else branch to call preVisit() instead of visit()? I.e. super.preVisit(tree, P).

This comment has been minimized.

Sign in to view

Copy link
@knutwannheden

knutwannheden Jul 9, 2024

Contributor

I suppose it will now just end up calling defaultValue() since u is null.
Expand Down

0 comments on commit 1c11e1f

Please sign in to comment.