Spring Batch recipe for MigrateStepBuilderFactory

[desprez]

TEMPLATE_STOP tell me that something is missing by I don't know what

@Bean
Step myStep(JobRepository jobRepository) {
    return new StepBuilder("myStep", jobRepository)/*__TEMPLATE_STOP__*/
            ./*__TEMPLATE_STOP__*/<String, String>chunk(completionPolicy())
            .<String, String> chunk(completionPolicy())
            .reader(reader())
            .writer(writer())
            .build();
}

[sambsnyd]

Sorry I haven't had time to look at this yet, but I haven't forgotten

[alexpm-14]

Hello, I'm interested in this recipe as SpringBatch4To5Migration doesn't contains this migration yet. Is it pending of anything?
Thanks in advance.

[timtebeek]

Hello, I'm interested in this recipe as SpringBatch4To5Migration doesn't contains this migration yet. Is it pending of anything? Thanks in advance.

Hi @alexpm-14 ; I'd missed this comment as I wasn't subscribed to this thread yet; I've gone ahead and made some changes to adopt rewrite 8; that hasn't yet solved the template errors reported before, but at least one of the three tests now only has type issues, no longer any template issues, so there is some progress.

As for what's needed to complete this one: I don't exactly know; I'd have to dive in more, but don't currently have the time. You're welcome to explore if you're up for it; you can fork https://github.com/desprez/rewrite-spring/tree/main and see if that get's you closer. Feel free to tag me if you make a PR there or here, and I can try to work in a review.

[timtebeek]

@knutwannheden Perhaps you'd have an intuitive understanding of why we see template stop introduced here? A quick look would be appreciated if you're able to fit that in.

[timtebeek]

From looking at the problem briefly it appears this jobRepository variable does not yet exist in the context when the template is applied, because that's only added as a method argument in doAfterVisit(new RemoveStepBuilderFactoryVisitor(clazz, enclosingMethod)). That's then likely what triggers the template error, even if the produced output would otherwise textually be ok. It might help to introduce the method argument first, before using it here.

[timtebeek]

Reworked this a bit to ensure the JobRepository is now injected as a bean method argument before we use it in the new StepBuilder. Feel like I'm close but can't work out the final step.

[timtebeek]

Isolated the issue into this PR:

• Isolate JavaTemplate issue with generic type parameters rewrite#4372

[timtebeek]

Thanks for kicking this off @desprez , and you patience throughout. Wasn't easy to get this one across the line, given the JavaTemplate issue upstream, but we managed to polish this up into something I'm quite pleased with now.