Remove unwanted characters from error message #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error message currently says "There were problems parsing 7 + sources:". Looking at the git history the plus sign in the output is probably from a string concatenation that made it into the string literal by accident.
|
I'm going to agree with you here that the message is sub optimal. Ideally I think we additionally run Slf4jBestPractices to parameterize the logging statement instead of using String concatenation; should be an easy follow up after this is merged. Thanks for pointing it out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
The error message for resources with parse errors.
What's your motivation?
The error message currently says "There were problems parsing 7 + sources:".
Looking at the git history the plus sign in the output is probably from a string concatenation that made it into the string literal by accident.
Checklist
n.a.