chore: drop legacy, use resolver

[cstamas]

Changes:

• skip uses of archaic classes, use resolver
• update wrapper to latest, set wrapped Maven to 3.9.2
• update ITs to mute "plugin validation"

[cstamas]

@SoEBeS @khmarbaise Something is off re ITs: all IT classes are annotated with @MavenOption(MavenCLIOptions.NO_TRANSFER_PROGRESS) (on class level), but IT classes having more than one method on second and subsequent invocations have it not applied (there is download progress). Naturally same stands for "mute 3.9.2 plugin validation" as well...

Example: BasicIT groupid_artifactid_should_be_ok mvn-arguments:

/home/cstamas/.sdkman/candidates/maven/current/bin/mvn
-Dmaven.repo.local=/home/cstamas/Worx/openrewrite/rewrite-maven-plugin/target/maven-it/org/openrewrite/maven/BasicIT/groupid_artifactid_should_be_ok/.m2/repository
--no-transfer-progress
-Dorg.slf4j.simpleLogger.log.org.apache.maven.plugin.internal.DefaultPluginValidationManager=off
package

but BasicIT null_check_profile_activation:

/home/cstamas/.sdkman/candidates/maven/current/bin/mvn
-Dmaven.repo.local=/home/cstamas/Worx/openrewrite/rewrite-maven-plugin/target/maven-it/org/openrewrite/maven/BasicIT/null_check_profile_activation/.m2/repository
--settings
settings.xml
org.openrewrite.maven:rewrite-maven-plugin:4.47.0-SNAPSHOT:dryRun

(no progress and mute plugin validation missing)

[timtebeek]

I'm seeing one failure

ArtifactNotFoundException: Could not find artifact org.openrewrite.recipe:rewrite-testing-frameworks:jar:runtime:1.31.0 in central

Not sure if this change might be related.

-return repositorySystem.createArtifact(parts[0], parts[1], parts[2], "runtime", "jar");
+return new DefaultArtifact(parts[0], parts[1], "runtime", "jar", parts[2]);

Any insights there? I could also dive in; we already really appreciate you chiming in with this improvement here!

Any background as to what prompted you to contribute? Would love to help and discuss if there's anything more we can do.

[cstamas]

Yup, I mixed up two methods of old "repo sys" the createArtifact and same *withClassifier (assumed "runtime" is classifier, but is actually scope), fixing it.

[cstamas]

re contribution: was really just led to this project while was looking how Quarkus handles "project upgrade" of theirs... and as Maven dev, just wanted to give plugin an update (as it emits warning with Maven 3.9.x due use of ArtifactRepository type that misbehaves when "split repo: feature of new Maven is used, see https://issues.apache.org/jira/browse/MNG-7706).

[timtebeek]

re contribution: was really just led to this project while was looking how Quarkus handles "project upgrade" of theirs... and as Maven dev, just wanted to give plugin an update (as it emits warning with Maven 3.9.x due use of ArtifactRepository type that misbehaves when "split repo: feature of new Maven is used, see https://issues.apache.org/jira/browse/MNG-7706).

Appreciate the help! Already discussed with @mthmulders if there's anything we can do for Maven 4, such as reproducible builds by inserting plugin version numbers through a recipe, as well as dropping now optional parent version numbers. Happy to think through any other use cases you might have to help Maven developers & users.

[cstamas]

Am actually in process of update (major, as it lags a lot of maintenance) the maven-archetype, and had a wild idea to "merry" the archetype and some sort of rewrite (so to say, to keep archetypes "live", not one off), but this is maybe not archetype thing (that is essentially "just" template), but some plugin that amalgamates the two: uses archetype for commands like "add new module" to existing project, that creates new module out of some archetype, while uses rewrite to wire up new module into parent etc.

Am just tinkering, will ping once I have scratches around it.

[timtebeek]

Sure! Continuous maintenance on archetype-started projects sounds right up our alley with OpenRewrite and Moderne; Feel free to share your thoughts and progress, either here or via our public Slack.