Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rewrite.version properties on release #556

Merged
merged 1 commit into from
May 16, 2023

Conversation

timtebeek
Copy link
Contributor

This ensures we use the latest versions of rewrite modules with each release, in lieu of using RELEASE which made it into the released pom.xml.

@timtebeek timtebeek added the enhancement New feature or request label May 14, 2023
@timtebeek timtebeek requested a review from sambsnyd May 14, 2023 13:13
@timtebeek timtebeek self-assigned this May 14, 2023
@timtebeek timtebeek requested a review from knutwannheden May 16, 2023 14:17
@knutwannheden
Copy link
Contributor

Sounds good. Is this a separate workflow? Maybe we could also have one to upgrade to the latest snapshot after making a new release.

@timtebeek
Copy link
Contributor Author

Right now it's part of the release flow (untested, as I'd have to do a release first).

I like your suggestion of updating the properties to the latest snapshot version after a release;
we can look at that if this first step succeeds, and then conditionally add that on release success.

@timtebeek timtebeek merged commit 2282a0d into main May 16, 2023
@timtebeek timtebeek deleted the tim/bump_rewrite.version_on_release branch May 16, 2023 15:03
@timtebeek
Copy link
Contributor Author

This worked: 0667ddd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants