Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let Maven resolve settings.xml content for us, get values from MavenExecutionRequest #262

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Let Maven resolve settings.xml content for us, get values from MavenExecutionRequest #262

merged 1 commit into from
Dec 8, 2021

Conversation

aegershman
Copy link
Contributor

@aegershman aegershman commented Dec 7, 2021 •
edited
Loading

See: #152

@aegershman aegershman force-pushed the resolve-settings-from-maven branch from caa1e21 to 6782bc0 Compare December 7, 2021 22:46
@aegershman aegershman self-assigned this Dec 7, 2021
@aegershman aegershman marked this pull request as ready for review December 7, 2021 23:05
@aegershman aegershman force-pushed the resolve-settings-from-maven branch from 6782bc0 to 613241c Compare December 7, 2021 23:07
sambsnyd
sambsnyd approved these changes Dec 7, 2021
View reviewed changes
Copy link
Member

@sambsnyd sambsnyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable

@aegershman aegershman merged commit 4846f87 into main Dec 8, 2021
@aegershman aegershman deleted the resolve-settings-from-maven branch December 8, 2021 06:18
aegershman added a commit that referenced this pull request Dec 8, 2021
@aegershman
[#262] URI parsing exception may still occur if the variable value is…
9a2e834 
… not interpolated, because Maven tolerates unresolved variables in settings
@aegershman aegershman mentioned this pull request Dec 8, 2021
Merged
aegershman added a commit that referenced this pull request Dec 8, 2021
@aegershman
[#262] Test for uninterpolated settings repo urls
32cb9e8
aegershman added a commit that referenced this pull request Dec 8, 2021
@aegershman
[#262] build MavenSettings with plain setters where necessary
7cd4492
@aegershman aegershman added this to the 4.17.0 milestone Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sambsnyd sambsnyd sambsnyd approved these changes

Assignees

@aegershman aegershman

Labels
None yet
Projects
None yet
Milestone
4.17.0
Development

Successfully merging this pull request may close these issues.
2 participants
@aegershman @sambsnyd