New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix check inputs, disallow negative scores, update default thresholds #289

Open

YixuanEvenXu wants to merge 1 commit into openreview:master from YixuanEvenXu:fix/perturbed-maximization

Collaborator

YixuanEvenXu commented Nov 26, 2024

This pull request changes the following three things:

It fixes the bug that input checking fails when some floating number parameters are integers.
It disallows negative matching scores to ensure the optimization is concave.
It updates the default values of the parameters bad_match_thresholds to the same with what was used in NeurIPS 2024.


          fix check inputs, disallow negative scores, update default thresholds

4efcb76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet