Add ability to direct app GPU support #2134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There apparently are some circumstances when an application can
benefit from disabling the internal GPU support in one or more
of its libraries. Let's assume that a library might also provide
a mechanism by which that support can be defaulted to enabled
or disabled.
Add CLI support for specifying that GPU support be enabled or
disabled. We assume that:
(a) this is something that a tool might want to enquire about
to see what an app was told to do
(b) a user might want/expect this to be a directive inherited
by any spawned child jobs
Also note that there was a lot of code duplication between
prte and prun_common when it came to parsing the cmd line
for job-level directives. Collect those in a common function
as we see that some divergence had already occurred.
Signed-off-by: Ralph Castain <rhc@pmix.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There apparently are some circumstances when an application can benefit from disabling the internal GPU support in one or more of its libraries. Let's assume that a library might also provide a mechanism by which that support can be defaulted to enabled or disabled.
Add CLI support for specifying that GPU support be enabled or disabled. We assume that:
(a) this is something that a tool might want to enquire about
to see what an app was told to do
(b) a user might want/expect this to be a directive inherited
by any spawned child jobs
Also note that there was a lot of code duplication between prte and prun_common when it came to parsing the cmd line for job-level directives. Collect those in a common function as we see that some divergence had already occurred.
Refs openpmix/openpmix#3528