Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align KEM Combiner and drop ECDH-KEM CCA-conversion #161

Merged
merged 7 commits into from
Dec 17, 2024
Merged

Align KEM Combiner and drop ECDH-KEM CCA-conversion #161

merged 7 commits into from
Dec 17, 2024

Conversation

fluppe2
Copy link
Collaborator

@fluppe2 fluppe2 commented Nov 28, 2024

  • Modified KEM Combiner
  • Dropped ECDH-KEM CCA-conversion
  • Aligned security considerations
  • Removed and added references appropriately
  • Added Changelog under -07

@fluppe2 fluppe2 linked an issue Nov 28, 2024 that may be closed by this pull request
KEM Combiner Option 2a #160
Closed
TJ-91
TJ-91 reviewed Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@TJ-91 TJ-91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, only some minor editorial comments.

draft-ietf-openpgp-pqc.md Outdated Show resolved Hide resolved
draft-ietf-openpgp-pqc.md Outdated Show resolved Hide resolved
draft-ietf-openpgp-pqc.md Outdated Show resolved Hide resolved
falko-strenzke
falko-strenzke reviewed Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@falko-strenzke falko-strenzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In principle it's fine in my judgement, we should just decide on / process the open comments.

wussler
wussler approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@wussler wussler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good to me. I'll follow up on the list with a link to this PR

fluppe2 and others added 3 commits November 28, 2024 21:46
@fluppe2 @TJ-91
Hyphen in OpenPGP-specific
493ec1f 
Co-authored-by: Johannes Roth <johannes.roth@mtg.de>
@fluppe2 @TJ-91
Hyphen in IND-CCA2-secure
4b75a68 
Co-authored-by: Johannes Roth <johannes.roth@mtg.de>
@fluppe2
Rephrased KEM combiner description a little
0b16057
lubux added a commit to ProtonMail/go-crypto that referenced this pull request Nov 29, 2024
@lubux
feat: Update key KEM combiner to latest draft
d188e97 
See:
openpgp-pqc/draft-openpgp-pqc#161
ahuelsing
ahuelsing approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@ahuelsing ahuelsing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, although I personally would prefer PK instead of P as that may be read as plaintext by some.

@falko-strenzke
Copy link
Collaborator

Looks good to me, although I personally would prefer PK instead of P as that may be read as plaintext by some.

I agree with Andreas, it should better be "PK1" etc.

@fluppe2
Copy link
Collaborator Author

fluppe2 commented Dec 4, 2024

Looks good to me, although I personally would prefer PK instead of P as that may be read as plaintext by some.

I agree with Andreas, it should better be "PK1" etc.

Good catch, see 88d3fd1.

lubux added a commit to ProtonMail/go-crypto that referenced this pull request Dec 5, 2024
@lubux
feat: ML-KEM change key combiner to latest draft
b5dbf0e 
See:
openpgp-pqc/draft-openpgp-pqc#161
larabr added a commit to ProtonMail/openpgpjs that referenced this pull request Dec 13, 2024
@larabr
PQC: switch to latest proposed variant for draft 7 of ML-KEM with X25519
5fe43e6 
Which also drops ECDH-KEM CCA-conversion.
This variant is yet to be adopted under draft 7, hence official test
vectors aren't available for now.

See openpgp-pqc/draft-openpgp-pqc#161 .
wussler
wussler reviewed Dec 17, 2024
View reviewed changes
draft-ietf-openpgp-pqc.md Outdated Show resolved Hide resolved
@fluppe2 @wussler
Typo
e981777 
Co-authored-by: Aron Wussler <aron@wussler.it>
@fluppe2 fluppe2 merged commit 9999219 into main Dec 17, 2024
2 checks passed
@wussler wussler mentioned this pull request Dec 17, 2024
Closed
lubux added a commit to ProtonMail/go-crypto that referenced this pull request Jan 7, 2025
@lubux
feat: ML-KEM change key combiner to latest draft
376764e 
See:
openpgp-pqc/draft-openpgp-pqc#161
lubux added a commit to ProtonMail/go-crypto that referenced this pull request Jan 15, 2025
@lubux
feat: ML-KEM change key combiner to latest draft
59cb1c8 
See:
openpgp-pqc/draft-openpgp-pqc#161
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TJ-91 TJ-91 TJ-91 left review comments

@wussler wussler wussler approved these changes

@falko-strenzke falko-strenzke falko-strenzke approved these changes

@ahuelsing ahuelsing ahuelsing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KEM Combiner Option 2a
5 participants
@fluppe2 @falko-strenzke @wussler @ahuelsing @TJ-91