Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OfficeAtWeb Can be null and use *optStr #62

Merged
merged 1 commit into from
Mar 6, 2020
Merged

OfficeAtWeb Can be null and use *optStr #62

merged 1 commit into from
Mar 6, 2020

Conversation

ger-benjamin
Copy link
Contributor

Two changes:

  • OfficeAtWeb Can be null: support it with a default string value to ``.
  • Use *optStr to avoid default value repetition

Relative to https://github.com/openoereb/pyramid_oereb/pull/1010/files
Notices can have no authority_at_web (office_at_web in pyramid_oereb), and having no office_at_web is supported in pyramid_oereb but not here in the print.

@ger-benjamin ger-benjamin self-assigned this Mar 4, 2020
@ger-benjamin ger-benjamin mentioned this pull request Mar 4, 2020
Merged
marionb
marionb approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@marionb marionb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jwkaltz
jwkaltz reviewed Mar 4, 2020
View reviewed changes
Copy link
Member

@jwkaltz jwkaltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the necessary changes to mapfish print configuration in the changes.rst (of the pyramid_oereb project pull request)

@ger-benjamin
Copy link
Contributor Author

@jwkaltz It's now added in the pyramid_oereb related PR

@ger-benjamin ger-benjamin merged commit ec740c1 into master Mar 6, 2020
@ger-benjamin ger-benjamin deleted the better_optional_strings branch March 6, 2020 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwkaltz jwkaltz jwkaltz left review comments

@marionb marionb marionb approved these changes

@voisardf voisardf Awaiting requested review from voisardf

Assignees

@ger-benjamin ger-benjamin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ger-benjamin @marionb @jwkaltz