Use individual wms url parameters for the baseLayers #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he restriction_on_landownership
91c927f to
7cea1df
Compare
f539b11 to
72cd48c
Compare
72cd48c to
c4cccf1
Compare
jwkaltz
reviewed
Jan 9, 2020
jwkaltz
reviewed
Jan 9, 2020
jwkaltz
reviewed
Jan 9, 2020
| """ | ||
| Returns the list of additionally configured wms_url_params. | ||
| Args: | ||
| params: optional argument used for given custom parameters. Expecting a dict |
There was a problem hiding this comment.
Suggested change
| params: optional argument used for given custom parameters. Expecting a dict | |
| params (dict): Optional argument used for given custom parameters. |
See another function to have the right syntax to generate the documentation (I'm not sure for your "return" doc)
| else: | ||
| log.info("no wms_url_params configuration detected; using default value") | ||
| result = {'TRANSPARENT': 'true'} | ||
| for param_key, param_value in params.items(): # TODO make this Python 2.x compatible! |
There was a problem hiding this comment.
What about this todo ?
|
@ger-benjamin Thanks for the review. Actually after discussion with @jwkaltz I decided to redo most of this and opened a new PR #986 . Your I fixed your comments there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://jira.camptocamp.com/browse/GEO-2777
Adds a parameter to get all the config Params from a URL and add them in the print request for that map.
This is implemented for the base maps requested in the
restriction on landownership