Add plr sorting hook #979
Merged
Add plr sorting hook #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ger-benjamin
reviewed
Jan 7, 2020
ger-benjamin
reviewed
Jan 7, 2020
kdeininger
approved these changes
Jan 9, 2020
There was a problem hiding this comment.
I think we already had a discussion about sorting in pyramid_oereb. If I remember rightly, the result was to implement no sorting because this step should be done in the client application according to its special needs. Otherwise, you will have to rely on the extract to be parsed in the right order. The only exception is the print proxy for Mapfish Print, which acts as kind of client.
But anyway, if it is a requirement to get a sorted extract, this PR looks good to me.
Co-Authored-By: Benjamin <benjamin.gerber@camptocamp.com>
Co-Authored-By: Benjamin <benjamin.gerber@camptocamp.com>
137425f to
4ea47d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new hook, to be able to define a sorting of the plrs within the themes in the extract data.
It also proposes a contrib method for one specific sorting implementation, by type_code, as requested by @romefi . This contrib method can be tested by defining in the project configuration file the following:
sort_within_themes_method: pyramid_oereb.contrib.plr_sort_within_themes_by_type_code
(see example in new standard configuration file)
C2C reference ticket: GEO-2844