Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sorting for LegalProvisions, Hints and Laws #925

Merged
merged 3 commits into from
Oct 28, 2019
Merged

Add sorting for LegalProvisions, Hints and Laws #925

merged 3 commits into from
Oct 28, 2019

Conversation

marionb
Copy link
Contributor

@marionb marionb commented Oct 24, 2019 •
edited by jwkaltz
Loading

This PR sorts:

  • LegalProvisions according to:
    - Title
    - Office number
    - Text at web
  • Laws according to:
    - OfficialNumber (if this attribute is empty the element will be placed at the end of the list)
    - Title
  • Hints according to:
    - Title
    As described in https://jira.camptocamp.com/browse/GEO-2554

This PR addresses #818

@openoereb openoereb deleted a comment Oct 24, 2019
@marionb marionb force-pushed the sorting-LegalProvision-GEO-2554 branch from cd00ffb to 0145917 Compare October 24, 2019 06:00
@openoereb openoereb deleted a comment Oct 24, 2019
@marionb marionb requested review from jwkaltz and pfirpfel October 24, 2019 06:27
@marionb
Copy link
Contributor Author

marionb commented Oct 24, 2019

@CoNussberger can you pleas test this with your data?

@jwkaltz jwkaltz requested a review from kdeininger October 24, 2019 07:01
kdeininger
kdeininger requested changes Oct 25, 2019
View reviewed changes
Copy link
Collaborator

@kdeininger kdeininger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but legal provisioning should be changed to legal provision.

@kdeininger kdeininger requested a review from vvmruder October 25, 2019 06:32
@marionb marionb self-assigned this Oct 25, 2019
kdeininger
kdeininger approved these changes Oct 25, 2019
View reviewed changes
Copy link
Collaborator

@kdeininger kdeininger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks 👍

@jwkaltz jwkaltz merged commit 94c3836 into master Oct 28, 2019
@jwkaltz jwkaltz deleted the sorting-LegalProvision-GEO-2554 branch October 28, 2019 07:02
@jwkaltz jwkaltz mentioned this pull request Oct 28, 2019
Closed
@jwkaltz jwkaltz changed the title Add sorting for LegalProvisionig, Hints and Laws Add sorting for LegalProvisions, Hints and Laws May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdeininger kdeininger kdeininger approved these changes

@jwkaltz jwkaltz Awaiting requested review from jwkaltz

@pfirpfel pfirpfel Awaiting requested review from pfirpfel

@vvmruder vvmruder Awaiting requested review from vvmruder

Assignees

@marionb marionb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marionb @kdeininger @jwkaltz