Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new option for xml2pdf, and output more if request fails #905

Merged
merged 2 commits into from
Sep 12, 2019

Conversation

jwkaltz
Copy link
Member

@jwkaltz jwkaltz commented Sep 11, 2019

No description provided.

Add a little description to parameter
Copy link
Collaborator

@vvmruder vvmruder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I only added a littel description on it.

Copy link
Collaborator

@pramisters pramisters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jwkaltz jwkaltz merged commit 4b47c5e into master Sep 12, 2019
@jwkaltz jwkaltz deleted the option_for_xml2pdf branch September 12, 2019 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants