Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flexible print configuration #885

Merged
merged 12 commits into from
Oct 30, 2019
Merged

flexible print configuration #885

merged 12 commits into from
Oct 30, 2019

Conversation

jwkaltz
Copy link
Member

@jwkaltz jwkaltz commented Jul 19, 2019

Follow-up to PR #631:
Be able to flexibly choose print configuration for XML2PDF or for MapFish-Print.

@pfirpfel
Copy link
Contributor

  • the variable is not getting passed correctly yet

If you mean from Makefile to the rendered template, this also does not work for stuff like PG_USER/PG_PASSWORD.

.venv/bin/create_standard_yaml
.venv/bin/create_standard_yaml -p MapFishPrint
.venv/bin/create_standard_yaml -p XML2PDF

Work all fine.

@jwkaltz jwkaltz changed the title WIP: flexible print configuration flexible print configuration Jul 22, 2019
@jwkaltz jwkaltz changed the title flexible print configuration WIP: flexible print configuration Jul 22, 2019
@jwkaltz jwkaltz changed the title WIP: flexible print configuration flexible print configuration Jul 22, 2019
@vvmruder
Copy link
Collaborator

vvmruder commented Jul 22, 2019

For me this adds ways too much layers of complexity. Why not simply document the selectable print proxy and thats it.

Every user should be perfectly able to setup this in his pyramid oereb YAML. I don't think this helps anybody. Since user names and tokens need to be specified anyhow.

@jwkaltz
Copy link
Member Author

jwkaltz commented Jul 22, 2019

For me this adds ways too much layers of complexity. Why not simply document the selectable print proxy and thats it.

Every user should be perfectly able to setup this in his pyramid oereb YAML. I don't think this helps anybody. Since user names and tokens need to be specified anyhow.

This PR is the follow-up to #631 (comment)

I am not sure to understand your concern. For the user, nothing changes, s/he simply has an additional option when using the scripts to define which print backend s/he wants to use. If s/he does not use this option, there is a default. I don't see how this adds complexity, isn't this analog to the other configuration options?

@vvmruder
Copy link
Collaborator

In this comment I clearly point out my suggestions to leave it as integration problem.

I think adding all the possible options a config yaml could look like we will end up in a fairly complex environment. And I want to keep it simple as possible. As I said: At least the credential need to be filled in later by hand.

And the standard configuration should only act as a starting point. All customisation will be done by hand later.

@vvmruder vvmruder requested review from voisardf and pramisters July 22, 2019 14:12
Copy link
Collaborator

@voisardf voisardf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks

@jwkaltz jwkaltz force-pushed the flexible_print_conf branch from 1fb0106 to f763fcf Compare August 5, 2019 15:28
@jwkaltz jwkaltz force-pushed the flexible_print_conf branch from 80076e6 to 5ef2aa7 Compare October 30, 2019 11:44
@jwkaltz jwkaltz merged commit 236b589 into master Oct 30, 2019
@jwkaltz jwkaltz deleted the flexible_print_conf branch October 30, 2019 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants