-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flexible print configuration #885
Conversation
If you mean from Makefile to the rendered template, this also does not work for stuff like PG_USER/PG_PASSWORD.
Work all fine. |
For me this adds ways too much layers of complexity. Why not simply document the selectable print proxy and thats it. Every user should be perfectly able to setup this in his pyramid oereb YAML. I don't think this helps anybody. Since user names and tokens need to be specified anyhow. |
This PR is the follow-up to #631 (comment) I am not sure to understand your concern. For the user, nothing changes, s/he simply has an additional option when using the scripts to define which print backend s/he wants to use. If s/he does not use this option, there is a default. I don't see how this adds complexity, isn't this analog to the other configuration options? |
In this comment I clearly point out my suggestions to leave it as integration problem. I think adding all the possible options a config yaml could look like we will end up in a fairly complex environment. And I want to keep it simple as possible. As I said: At least the credential need to be filled in later by hand. And the standard configuration should only act as a starting point. All customisation will be done by hand later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks
1fb0106
to
f763fcf
Compare
… is was before this PR)
80076e6
to
5ef2aa7
Compare
Follow-up to PR #631:
Be able to flexibly choose print configuration for XML2PDF or for MapFish-Print.