Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add print configuration parameter for municipality name #1703

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

jwkaltz
Copy link
Member

@jwkaltz jwkaltz commented Feb 17, 2023

Related to openoereb/pyramid_oereb_mfp#129:
as discussed in openoereb/pyramid_oereb_mfp#130, instead of removing the municipality name in the PDF output, a configuration option is introduced.

@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #1703 (1d29a8b) into master (c2a2ced) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1703   +/-   ##
=======================================
  Coverage   77.51%   77.51%           
=======================================
  Files         127      127           
  Lines        5212     5213    +1     
=======================================
+ Hits         4040     4041    +1     
  Misses       1172     1172           
Flag Coverage Δ
unittests 77.51% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...contrib/print_proxy/mapfish_print/mapfish_print.py 86.73% <100.00%> (+0.03%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@marionb marionb merged commit fef6ab2 into master Feb 27, 2023
@marionb marionb deleted the print_option_municipality_name branch February 27, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants