Improving GetEGRID performance #1680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1680 +/- ##
==========================================
+ Coverage 77.50% 77.51% +0.01%
==========================================
Files 127 127
Lines 5209 5212 +3
==========================================
+ Hits 4037 4040 +3
Misses 1172 1172
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
This PR tries to fix #1679 |
michmuel
approved these changes
Jan 16, 2023
vvmruder
approved these changes
Jan 20, 2023
There was a problem hiding this comment.
This is a good catch. It goes in the right direction-since we load config on server boot, the next improvement can be based on that. THX @peterschaer
|
Hi @peterschaer , please feel free to merge your request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change the request time goes down to 200ms on my development environment. On production it may even be quicker. Maybe someone has a more elegant solution.