Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shapely deprecation warnings #1647

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Conversation

jwkaltz
Copy link
Member

@jwkaltz jwkaltz commented Dec 28, 2022

Fix shapely deprecation warnings (in preparation for upgrade to Shapely 2)

@jwkaltz jwkaltz marked this pull request as ready for review December 28, 2022 09:28
@jwkaltz jwkaltz mentioned this pull request Dec 28, 2022
10 tasks
@codecov
Copy link

codecov bot commented Dec 28, 2022

Codecov Report

Merging #1647 (8c8542a) into master (47d7d69) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1647      +/-   ##
==========================================
- Coverage   77.55%   77.54%   -0.01%     
==========================================
  Files         127      127              
  Lines        5234     5233       -1     
==========================================
- Hits         4059     4058       -1     
  Misses       1175     1175              
Flag Coverage Δ
unittests 77.54% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyramid_oereb/core/records/geometry.py 90.69% <100.00%> (-0.08%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jwkaltz jwkaltz requested review from michmuel and voisardf December 28, 2022 09:38
@jwkaltz jwkaltz mentioned this pull request Dec 28, 2022
1 task
Copy link
Collaborator

@voisardf voisardf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and working for me, including the PDF generation with identical results (areas) for a test real-estate

@jwkaltz jwkaltz merged commit 780e2f1 into master Jan 4, 2023
@jwkaltz jwkaltz deleted the fix_shapely_deprecation_warnings branch January 4, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants