Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to always add real estate geometry in XML extract #1619

Merged
merged 2 commits into from
Dec 15, 2022

Conversation

jwkaltz
Copy link
Member

@jwkaltz jwkaltz commented Dec 13, 2022

Add configuration parameter to always add real estate geometry in XML extract,
independently of general parameter GEOMETRY.

Use case: producing the extract for the xml2pdf service, which requires the real estate geometry (limit), but not all geometries. Having this configuration possibility reduces the size of the payload sent to the print service by up to 50%.

Tested on Glarus server.

@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Merging #1619 (05d772f) into master (85f816b) will increase coverage by 9.98%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1619      +/-   ##
==========================================
+ Coverage   67.76%   77.74%   +9.98%     
==========================================
  Files         121      127       +6     
  Lines        5038     5222     +184     
==========================================
+ Hits         3414     4060     +646     
+ Misses       1624     1162     -462     
Flag Coverage Δ
unittests 77.74% <100.00%> (+9.98%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyramid_oereb/core/config.py 80.42% <100.00%> (+0.10%) ⬆️
pyramid_oereb/__init__.py 34.48% <0.00%> (ø)
pyramid_oereb/contrib/__init__.py 9.67% <0.00%> (ø)
pyramid_oereb/core/renderer/__init__.py 89.33% <0.00%> (ø)
pyramid_oereb/core/records/__init__.py 100.00% <0.00%> (ø)
pyramid_oereb/core/readers/__init__.py 100.00% <0.00%> (ø)
pyramid_oereb/core/sources/__init__.py 79.06% <0.00%> (ø)
...trib/data_sources/standard/sources/municipality.py 100.00% <0.00%> (+7.69%) ⬆️
...ereb/contrib/data_sources/standard/sources/logo.py 100.00% <0.00%> (+9.09%) ⬆️
...reb/contrib/data_sources/standard/sources/theme.py 100.00% <0.00%> (+9.09%) ⬆️
... and 22 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

… combination with having the real estate's geometry
Copy link
Collaborator

@michmuel michmuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not test it, but the code looks good to me.

Copy link
Collaborator

@voisardf voisardf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@jwkaltz jwkaltz merged commit bd4d878 into master Dec 15, 2022
@jwkaltz jwkaltz deleted the option_for_realestate_with_geom branch December 15, 2022 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants