Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oereblex-prepub #1618

Merged
merged 5 commits into from
Dec 14, 2022
Merged

oereblex-prepub #1618

merged 5 commits into from
Dec 14, 2022

Conversation

michmuel
Copy link
Collaborator

@michmuel michmuel commented Nov 30, 2022

Add support for OerebLex-Prepublinks (#1617)

  • doctype "prepublink" is treated equally than doctype "decree" except of the enactment_date (start_status_date)

@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Merging #1618 (0b1fb94) into master (85f816b) will increase coverage by 9.76%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1618      +/-   ##
==========================================
+ Coverage   67.76%   77.53%   +9.76%     
==========================================
  Files         121      127       +6     
  Lines        5038     5230     +192     
==========================================
+ Hits         3414     4055     +641     
+ Misses       1624     1175     -449     
Flag Coverage Δ
unittests 77.53% <0.00%> (+9.76%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../contrib/data_sources/oereblex/sources/document.py 0.00% <0.00%> (ø)
pyramid_oereb/core/config.py 80.18% <0.00%> (-0.14%) ⬇️
pyramid_oereb/core/renderer/__init__.py 89.33% <0.00%> (ø)
pyramid_oereb/core/records/__init__.py 100.00% <0.00%> (ø)
pyramid_oereb/__init__.py 34.48% <0.00%> (ø)
pyramid_oereb/core/readers/__init__.py 100.00% <0.00%> (ø)
pyramid_oereb/contrib/__init__.py 9.67% <0.00%> (ø)
pyramid_oereb/core/sources/__init__.py 79.06% <0.00%> (ø)
...trib/data_sources/standard/sources/municipality.py 100.00% <0.00%> (+7.69%) ⬆️
...ereb/contrib/data_sources/standard/sources/logo.py 100.00% <0.00%> (+9.09%) ⬆️
... and 23 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jwkaltz
Copy link
Member

jwkaltz commented Dec 14, 2022

@michmuel thanks for the PR; in the title it is still called "draft", but it's no longer a draft, right?
If so, you can merge, and let me know if a new release is useful afterwards?

@michmuel michmuel changed the title draft: oereblex-prepub oereblex-prepub Dec 14, 2022
@michmuel michmuel merged commit 03a1e0f into master Dec 14, 2022
@michmuel michmuel deleted the oereblex-prepub branch December 14, 2022 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants