Static extract (PDF) without use_wms must embed the images

[jwkaltz]

For static extract (PDF) generation, when the PDF generation process shall not call the pyramid_oereb service to retrieve all the images (legend icons etc.), we need to embed the images within the extract.

Currently, the xml2pdf proxy contains a "use_wms" flag, but setting use_wms to false is only consistent when the extract contains images.

[codecov]

Codecov Report

Merging #1612 (548e8f9) into master (1e8352c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1612   +/-   ##
=======================================
  Coverage   67.74%   67.75%           
=======================================
  Files         121      121           
  Lines        5038     5039    +1     
=======================================
+ Hits         3413     3414    +1     
  Misses       1625     1625           

Flag	Coverage Δ
unittests	67.75% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pyramid_oereb/core/views/webservice.py	86.66% <100.00%> (+0.03%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[voisardf]

Code looks good to me, but I did not test it locally as we do not use the case without WMS.
do you have a possibility to test it for a canton?

[jwkaltz]

Code looks good to me, but I did not test it locally as we do not use the case without WMS. do you have a possibility to test it for a canton?

Partially, yes: I have tried this code change manually on the Glarus infrastructure, pyramid_oereb then does try to generate the extract with embedded images when use_wms = false. However, creating an extract WITHIMAGES currently generally fails at Glarus, but that's not directly related to this subject.