Geo 5769 tolerance per geom type

[mki-c2c]

New possibilities for configuration:
either leagsxy conf: tolerance + scalar
or new conf per geometry:
{"Point": 0.1, "Polygon": 0.05}
or dict for all:
{"ALL": 0.2}

[codecov]

Codecov Report

Merging #1603 (39976cc) into master (99095f8) will decrease coverage by 0.05%.
The diff coverage is 77.41%.

@@            Coverage Diff             @@
##           master    #1603      +/-   ##
==========================================
- Coverage   76.52%   76.47%   -0.06%     
==========================================
  Files         127      127              
  Lines        5185     5202      +17     
==========================================
+ Hits         3968     3978      +10     
- Misses       1217     1224       +7     

Flag	Coverage Δ
unittests	76.47% <77.41%> (-0.06%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pyramid_oereb/core/records/geometry.py	90.76% <62.50%> (-4.15%)	⬇️
...b/contrib/data_sources/interlis_2_3/sources/plr.py	81.76% <75.00%> (-0.36%)	⬇️
...oereb/contrib/data_sources/standard/sources/plr.py	51.05% <100.00%> (+0.78%)	⬆️
pyramid_oereb/core/records/plr.py	100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[jwkaltz]

Thanks @mki-c2c , the code looks good to me;
could we add an example configuration to https://github.com/openoereb/pyramid_oereb/blob/master/dev/config/pyramid_oereb.yml.mako ?

[mki-c2c]

@jwkaltz : you mean a commented stub in the config ? Because I am a bit afraid to put a default tolerance which changes quite significantly the search behaviour. So we might put some comments with a default configuration which can be uncommented by someone who wants to use this config ?

[jwkaltz]

@jwkaltz : you mean a commented stub in the config ? Because I am a bit afraid to put a default tolerance which changes quite significantly the search behaviour. So we might put some comments with a default configuration which can be uncommented by someone who wants to use this config ?

Yes you're right, the "standard configuration" shouldn't have that enabled.
So adding an example configuration for one of the themes (the first one which is of type geometrycollection is probably best), but commenting it out, seems to be the best approach.

[jwkaltz]

Thanks this looks good, but please undo the change of print base_url (not relevant here)

[jwkaltz]

This shouldn't be in this PR

[jwkaltz]

@svamaa perhaps this new feature is relevant for Basel-Stadt as well? As I understand, it addresses the need that @svareg had a while ago.

[vvmruder]

Looks ok code wise. About the tolerance check itself I fell still not convinced. But you get an approve.