UIFR-219: Client time zone saved as a user property for UiUtils' availability. #66
Conversation
Add new GP handling timezones.
Add new functions on uiutils about timezone and date formats from UiFramework
Add new date parses to be able to:
Parse from string with format ISO8601 to date
Parse Date format to string with RFC3339 format
Change function to format date to use fromISO8601
There was a problem hiding this comment.
I'm overall ok with it, except that we still need to nail the naming of this GP...
(@icrc-jfigueiredo also there's formatting issues, did you mvn package before pushing?)
api/src/main/java/org/openmrs/ui/framework/UiFrameworkConstants.java
Outdated
Show resolved
Hide resolved
…module-uiframework into HTML-755-2 � Conflicts: � api/src/main/java/org/openmrs/ui/framework/FormatterImpl.java � api/src/main/java/org/openmrs/ui/framework/UiFrameworkConstants.java � api/src/main/java/org/openmrs/ui/framework/UiUtils.java � api/src/main/java/org/openmrs/ui/framework/converter/StringToDateConverter.java � api/src/test/java/org/openmrs/ui/framework/FormatterImplTest.java
Add new GP handling timezones.
Add new functions on uiutils about timezone and date formats from UiFramework
Add new date parses to be able to:
Parse from string with format ISO8601 to date
Parse Date format to string with RFC3339 format
Change function to format date to use fromISO8601
|
@icrc-jfigueiredo it greatly helps the reviewer to separate formatting changes into their own pull request. |
| */ | ||
| public static String toTimezone(Date date, String format, String timezone) { | ||
| if (StringUtils.isEmpty(timezone)) { | ||
| timezone = "UTC"; |
There was a problem hiding this comment.
Do you wanna define a constant for UTC?
There was a problem hiding this comment.
Do you think is necessary? I only use it here.
There was a problem hiding this comment.
I replaces that "UTC" by import static org.joda.time.DateTimeZone.UTC
api/src/test/java/org/openmrs/ui/framework/FormatterImplTest.java
Outdated
Show resolved
Hide resolved
api/src/main/java/org/openmrs/ui/framework/UiFrameworkConstants.java
Outdated
Show resolved
Hide resolved
|
@icrc-jfigueiredo do we have a UIFramework JIRA ticket for this pull request? |
|
I am using this one: https://issues.openmrs.org/browse/HTML-755 but i can create a new one, if you think its necessary. |
|
It would be great to have them separate. |
|
So, one ticket for each PR ? |
|
The htmlformentry module JIRA ticket for changes in the htmlformentry module. A UIFramework JIRA ticket for changes in the uiframework module. But if no changes were made in the htmlformentry module as part of this ticket, then can just move this ticket to the UIFramework JIRA project without creating a new one. |
Ticket:
https://issues.openmrs.org/browse/UIFR-219
What I have done:
UiUtilsto expose utility methods to ... [TBC]