Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) O3-4181 Display Patient Age and Implement View/Edit Results Functionality for Lab Technicians #99

Merged
merged 7 commits into from
Nov 21, 2024

Conversation

its-kios09
Copy link
Contributor

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Screenshots

updates-lab

Related Issue

see: https://openmrs.atlassian.net/browse/O3-4181

Other

@pirupius
Copy link
Member

@its-kios09 did this design get these designs from zeplin? or does this have approval from the UI/UX team?

@pirupius pirupius self-requested a review November 11, 2024 12:13
@its-kios09
Copy link
Contributor Author

@its-kios09 did this design get these designs from zeplin? or does this have approval from the UI/UX team?

@pirupius I have brought up discussion on slack

@ojwanganto
Copy link
Contributor

@its-kios09 - let's separate adding the additional patient details from UI enhancements. The UI one will likely take some time to allow for proper designs

@its-kios09
Copy link
Contributor Author

@its-kios09 - let's separate adding the additional patient details from UI enhancements. The UI one will likely take some time to allow for proper designs

let me revert the enhancements

@its-kios09 its-kios09 changed the title feat O3-4181: Implement display Patient Age for Lab Technicians and UI enhancements feat O3-4181: Display Patient Age and Implement View/Edit Results Functionality for Lab Technicians Nov 14, 2024
@its-kios09
Copy link
Contributor Author

@ojwanganto I've completed the update. The latest version is in the GIF video.

updated-order

@its-kios09
Copy link
Contributor Author

@pirupius, I have reverted the UI to the previous version due to UI/UX concerns. The current changes include the addition of patient details such as patient age and the ability to view and edit lab results.

Copy link
Member

@pirupius pirupius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @its-kios09 some minor comments and clean ups to do before we can get this in

src/routes.json Outdated Show resolved Hide resolved
src/laboratory-resource.ts Outdated Show resolved Hide resolved
src/components/orders-table/patient-age.component.tsx Outdated Show resolved Hide resolved
@pirupius pirupius changed the title feat O3-4181: Display Patient Age and Implement View/Edit Results Functionality for Lab Technicians (feat) O3-4181 Display Patient Age and Implement View/Edit Results Functionality for Lab Technicians Nov 19, 2024
@its-kios09
Copy link
Contributor Author

its-kios09 commented Nov 19, 2024

@pirupius Hello Pius, I investigated where we could retrieve the patient’s age using the existing hooks. I think I have an idea of doing a custom representation to achieve that

@its-kios09 its-kios09 requested a review from pirupius November 20, 2024 11:40
@its-kios09
Copy link
Contributor Author

@pirupius I found an alternative way to retrieve the age from the existing hook by updating the v=full to a custom representation, and it is working well and optimized. however I have updated the PR
Let me know if you need any further adjustments!

@its-kios09 its-kios09 requested a review from pirupius November 21, 2024 13:51
@pirupius pirupius merged commit 2961db8 into openmrs:main Nov 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants