Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) Update translations from Transifex: Adds French translations for esm-laboratory-app and updates other missing French translations #96

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 4, 2024

Automated updates of translations pulled from Transifex

@github-actions github-actions bot force-pushed the chore/update-transifex branch 3 times, most recently from c6f5f82 to c02ccac Compare October 10, 2024 23:15
@gracepotma gracepotma self-requested a review October 11, 2024 16:39
@github-actions github-actions bot force-pushed the chore/update-transifex branch from c02ccac to 7aaefc6 Compare October 11, 2024 16:41
@gracepotma
Copy link

The main goal of this PR is to add French translations to the esm-laboratory-app.

I'd like to merge this today so I can check how it's looking in the dev3 UI.

Side note; I do realize that as of this moment, the PR is showing that english strings are being added to a few non-english areas; I've just gone through Transifex and cleaned all that up. Trying to use automated runs to ensure we avoid these.

@github-actions github-actions bot force-pushed the chore/update-transifex branch from 7aaefc6 to 242feff Compare October 11, 2024 16:52
@gracepotma
Copy link

OK discussed w/ Ian: Apparently this is expected behavior. English is the source language so where Transifex doesn’t have a translation for, e.g., cancel in Turkish, it just feeds in the English string.
Basically if you look at the translations anywhere else, you’ll see the same pattern.
The real issue is when the key or English translation changes and Transifex drops the existing translation.

@gracepotma gracepotma merged commit d024dc2 into main Oct 11, 2024
@gracepotma gracepotma deleted the chore/update-transifex branch October 11, 2024 18:10
@gracepotma gracepotma changed the title (chore) Update translations from Transifex (chore) Update translations from Transifex: Adds French translations for esm-laboratory-app and updates other missing French translations Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants