Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replaced single date picker for date range picker in the lab results component. #90

Merged

Conversation

amosmachora
Copy link
Contributor

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

In this PR I have added a date range picker to allow for fetching of data by date ranges. As highlighted by @donaldkibet here it makes it easier to track and follow up on ordered test results.

While I was at it I refactored the loading state a little bit to make the UI consistent between loading and loaded states. to reduce the amount of 'layout shift' that happens.

Screenshots

image

Related Issue

https://openmrs.atlassian.net/browse/O3-3916

Other

@ojwanganto
Copy link
Contributor

Do you mind attaching a video as well?

@donaldkibet
Copy link
Member

Thanks @amosmachora just one comment, can we have the filter persist across the tabs i.e if we filter test order for a certain during we should retain that range when we transition the tests to picked up orders

@donaldkibet donaldkibet merged commit 3399318 into openmrs:main Sep 9, 2024
4 checks passed
@donaldkibet
Copy link
Member

@amosmachora please follow up with a PR

@amosmachora
Copy link
Contributor Author

Got it @donaldkibet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants