(fix) O3-3589: Enable data table to search based on all table columns #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks @arodidev , there seems to be a preference to using debounce while doing searches. Is it something you would consider?
|
I'll work on adding the same, thanks @CynthiaKamau |
samuelmale
reviewed
Jul 16, 2024
| }; | ||
| }); | ||
|
|
||
| if (searchString && searchString.trim() !== "") { |
There was a problem hiding this comment.
You want to do this soft check before the mapping above so that we return early incases of an empty search term.
| orderer: string; | ||
| } | ||
|
|
||
| function useSearchResults(tableEntries: Order[], searchString): CustomOrder[] { |
There was a problem hiding this comment.
Suggested change
| function useSearchResults(tableEntries: Order[], searchString): CustomOrder[] { | |
| function useOrdersSearchResults(orders: Order[], searchTerm): CustomOrder[] { |
Can you define this hook in a separate file?
There was a problem hiding this comment.
Thanks, forgot to relocate this
Comment on lines
56
to
65
| const flattenedData = tableEntries.map((eachObject) => { | ||
| return { | ||
| ...eachObject, | ||
| dateActivated: formatDate(parseDate(eachObject.dateActivated)), | ||
| patient: eachObject.patient?.display.split("-")[1], | ||
| patientUuid: eachObject.patient?.uuid, | ||
| status: eachObject.fulfillerStatus ?? "--", | ||
| orderer: eachObject.orderer?.display.split("-")[1], | ||
| }; | ||
| }); |
There was a problem hiding this comment.
Should we be doing this mapping on every search event?
There was a problem hiding this comment.
I'll memoize this and pass it as an argument.
CynthiaKamau
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR fixes an issue with the data table search bar whereby the search was being made based on specific column. This fix introduces a more inclusive search that targets all the columns in the table.
Screenshots
Screen.Recording.2024-07-16.at.07.17.29.mov
Related Issue
https://openmrs.atlassian.net/browse/O3-3589
Other