(fix) : fix the non display of the approved or completed table #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirupius
reviewed
Mar 2, 2024
Comment on lines
107
to
108
| className={styles.statusContainer} | ||
| style={{ color: `${getStatusColor(entry.fulfillerStatus)}` }} |
There was a problem hiding this comment.
Are there any extra styles in the statusContainer class? trying to access if it's still relevant after this refactor
There was a problem hiding this comment.
Looks like this is really relevant since it provides for the background of the table
Comment on lines
+7
to
+14
| "pages": [ | ||
| { | ||
| "component": "root", | ||
| "route": "laboratory" | ||
| } | ||
| ], | ||
| "extensions": [ | ||
| { |
There was a problem hiding this comment.
Same applies to this json file. 2 spaces
pirupius
reviewed
Mar 4, 2024
208ec26 to
5d2f804
Compare
6d7ba9a to
9b5df73
Compare
pirupius
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR fixes the completed/ Approved table to display and also handles removal of unneccessay unused code.
Screenshots
Related Issue
Other