status:Filter lab orders by status

[gitcliff]

Requirements

• This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
• My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
• My work includes tests or is validated by existing tests.

Summary

This PR addresses the issue of filtering orders by status in the Tests ordered tab

Screenshots

https://www.loom.com/share/0a7d15e5f8384314b931aedb55c6d6c6?sid=7af4fda7-161f-4915-b03e-e7a94b93cf8b

Related Issue

Other

[pirupius]

Hi @gitcliff please update the description with the summary and screenshots to speed up the review process

[gitcliff]

Hi @gitcliff please update the description with the summary and screenshots to speed up the review process

thanks @pirupius ,,i have added them

[pirupius]

Hi @gitcliff i think this might have been of a mixture of approach for this. The values here are referenced in the backend so the translations isn't something that applies here otherwise someone can fix a typo thinking these texts don't have an impact but in reality the values have to stay intact.
One approach we could use is to map plain text to the values passed but for now let's just remove the translations so that this doesn't drag.

Suggested change

	const OrderStatuses = [
	t("all", "All"),
	t("received", "RECEIVED"),
	t("inProgressOrder", "IN_PROGRESS"),
	t("completedOrder", "COMPLETED"),
	t("exception", "EXCEPTION"),
	t("on_hold", "ON_HOLD"),
	t("decline", "DECLINED"),
	];
	const OrderStatuses = [
	"All",
	"RECEIVED",
	"IN_PROGRESS",
	"COMPLETED",
	"EXCEPTION",
	"ON_HOLD",
	"DECLINED",
	];

[gitcliff]

Hi @gitcliff i think this might have been of a mixture of approach for this. The values here are referenced in the backend so the translations isn't something that applies here otherwise someone can fix a typo thinking these texts don't have an impact but in reality the values have to stay intact. One approach we could use is to map plain text to the values passed but for now let's just remove the translations so that this doesn't drag.

thanks @pirupius ,,i have updated

[ojwanganto]

Thanks for this change. I know this comment might be coming in late but am wondering how the status' filter will be helpful specifically in the tests ordered tab. The risk is that the list will grow fast and long as it will contain tests that are no longer relevant in the lab. I expect tests with rejected or completed statuses to be removed from this list and made visible in the investigative results section of the patient chart.

[pirupius]

@ojwanganto you have a valid point and i think this comes down to aligning how we want to default tab setup to be. There's been a little bit of back and forth about this topic with different organizations having different requirements.

Work was previously done to make the tabs configurable and implementors can remove the ones they don't want to use which validates having a filter for such scenarios where multiple statuses are within the same tab. But this brings up and issue of a redundant filter in a tab with orders of the same status.

Hopefully this is someone we can agree on during the Tuesday labs call with all stakeholders present.