Feat/add numeric value ranges #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
109ba3e to
e50810d
Compare
jabahum
reviewed
Jan 30, 2024
| concept?.units ?? "" | ||
| })`; | ||
| } | ||
| return rangeString; |
There was a problem hiding this comment.
can we make the ranges or the Test bold atleast
There was a problem hiding this comment.
How is that done? inline styling?
pirupius
reviewed
Jan 31, 2024
src/results/result-form.resource.ts
Outdated
Comment on lines
22
to
27
| hiNormal: number; | ||
| hiAbsolute: number; | ||
| hiCritical: number; | ||
| lowNormal: number; | ||
| lowAbsolute: number; | ||
| lowCritical: number; |
There was a problem hiding this comment.
Are these generic to all concept responses? if not we should make them ternary
Suggested change
| hiNormal: number; | |
| hiAbsolute: number; | |
| hiCritical: number; | |
| lowNormal: number; | |
| lowAbsolute: number; | |
| lowCritical: number; | |
| hiNormal?: number; | |
| hiAbsolute?: number; | |
| hiCritical?: number; | |
| lowNormal?: number; | |
| lowAbsolute?: number; | |
| lowCritical?: number; |
src/results/result-form.resource.ts
Outdated
Comment on lines
168
to
173
| hiNormal: number; | ||
| hiAbsolute: number; | ||
| hiCritical: number; | ||
| lowNormal: number; | ||
| lowAbsolute: number; | ||
| lowCritical: number; |
There was a problem hiding this comment.
same comment applies here about adding the ternary
jabahum
approved these changes
Jan 31, 2024
|
Review comments addressed. Please check. @jabahum @pirupius @donaldkibet |
pirupius
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Display value ranges for numeric test results
Screenshots
Related Issue
Other