This repository has been archived by the owner on Jan 4, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
APPS-2313: CDSS WOA-5 Remediation of ADA compliance violations #40
Merged
bergieboy
merged 16 commits into
develop
from
feature/APPS-2315-pass-aria-label-to-LUK-select
Sep 24, 2020
Merged
APPS-2313: CDSS WOA-5 Remediation of ADA compliance violations #40
bergieboy
merged 16 commits into
develop
from
feature/APPS-2315-pass-aria-label-to-LUK-select
Sep 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UnsungHero97
suggested changes
Sep 22, 2020
UnsungHero97
suggested changes
Sep 22, 2020
UnsungHero97
previously approved these changes
Sep 22, 2020
anzioka
previously approved these changes
Sep 22, 2020
5eb7251
anzioka
approved these changes
Sep 23, 2020
solomontang
approved these changes
Sep 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the contrast of the placeholder in select, this is probably a change we wanna make to the luk repo
UnsungHero97
approved these changes
Sep 23, 2020
@@ -12,6 +12,7 @@ import { | |||
Spinner, | |||
ThemeProvider, | |||
lightTheme, | |||
StylesProvider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please sort.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APPS-2314 & APPS-2326: Ensure containing elements that allow text resize without loss of functionality.
This was raised by CDSS and the Lighthouse report in Chrome dev tools. The description and justification are below.
<meta>
tags always go inside the element and are typically used to specify a character set, page description, keywords, author of the document, and viewport settings. Metadata will not be displayed on the page but is machine parsable.user-scalable
attribute defines whether users can scale (zoom) the page content on mobile. By default, scaling is on, but if user-scalable is set to '0' or 'no' then this will prevent users from zooming, which negatively affects user experience (in most cases). For accessibility reasons though,user-scalable
needs to be set to yes and themaximum-scale
must be at least 5.Current:
<meta name="viewport" content="width=device-width, height=device-height, initial-scale=1.0, user-scalable=no, minimum-scale=1.0, maximum-scale=2.0">
Should be:
<meta name="viewport" content="width=device-width, height=device-height, initial-scale=1.0, user-scalable=yes, minimum-scale=1.0, maximum-scale=5.0">
APPS-2315: Provide a valid label for form fields.
Accessible Rich Internet Applications (ARIA) is a set of attributes that define ways to make web content and web applications (especially those developed with JavaScript) more accessible to people with disabilities.
aria-label
is a field that can be passed directly toreact-select
, which is below the hood of LUK'sSelect
. Passing this label resolves this issue.APPS-2327: Provide Adequate Contrast between placeholder and background on Select Component.
Raised by the Lighthouse report from Chrome dev tools.
Passing the 'themes' prop to LUK's
Select
component allows you to override the color that is used for the placeholder. I wish there were a cleaner way to achieve this, but this is the best solution I found. Open to other suggestions.const getPlaceholderTheme = (theme) => ({ ...theme, colors: { ...theme.colors, neutral50: '#555E6F' } });
<Select ... theme={getPlaceholderTheme} ... />
APPS-2316: Ensure ARIA roles, states, and properties are valid. [UPDATED]
using
useRef
to setref
on the Wrapper component, I was able to search its children for theinput
element and set the attribute,aria-autocomplete
, to 'none'. This should solve this issue.As far as I can tell, this is not achievable when usingreact-select
, which is what's under the hood for LUK'sSelect
and only allows foraria-label
andaria-labeledby
to be passed directly.aria-autocomplete
is set to list, but cannot be modified in any way that I have found yet. The PR listed below is from about a month ago in thereact-select
repo, and it would allow for you to passaria
properties, but it doesn't seem to have gotten much attention.PR for allowing any aria property