This repository has been archived by the owner on Nov 19, 2020. It is now read-only.
Feature/lattice 2228 external atlas access #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 24 commits
October 4, 2019 11:30
you-leee
reviewed
Nov 5, 2019
src/main/kotlin/com/openlattice/organization/OrganizationExternalDatabaseColumn.kt
Show resolved
Hide resolved
added 3 commits
November 5, 2019 14:00
…om:openlattice/api into feature/LATTICE-2228-external-atlas-access merge
src/main/java/com/openlattice/client/serialization/SerializationConstants.java
Outdated
Show resolved
Hide resolved
| companion object { | ||
| /* These determine the service routing */ | ||
| const val SERVICE = "/datastore" | ||
| const val CONTROLLER = "/organization-database" |
There was a problem hiding this comment.
This is just a general comment, but we've been super inconsistent in these controller paths between different patterns of first-second vs first_second vs firstsecondvs first/second so we should probably collectively pick whichever one we want and stick to that pattern moving forward
src/main/kotlin/com/openlattice/organization/OrganizationExternalDatabaseColumn.kt
Outdated
Show resolved
Hide resolved
katherinebernstein
suggested changes
Nov 6, 2019
added 10 commits
November 5, 2019 18:32
katherinebernstein
approved these changes
Nov 18, 2019
geekbeast
suggested changes
Nov 22, 2019
…om:openlattice/api into feature/LATTICE-2228-external-atlas-access
geekbeast
approved these changes
Nov 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creation and handling of securable object types that represent tables and columns of an organization's atlas database. These new securable objects will allow for creation of acl keys to enable granting permissions at the table or column level within atlas.
Also apis for granting permissions, updating table/column names