Implementing a generic Ingress based on Lua And A/B Testing Release #86

zmberg · 2022-09-22T11:47:26Z

Signed-off-by: liheng.zms liheng.zms@alibaba-inc.com

Ⅰ. Describe what this PR does

Implementing a generic Ingress based on Lua to support multiple ingress provider, e.g. nginx, aliyun-mse, aliyun-alb
support a/b testing release, headers or cookie

codecov-commenter · 2022-09-22T11:51:31Z

Codecov Report

Merging #86 (65c86a6) into master (f21c3fb) will increase coverage by 2.90%.
The diff coverage is 57.66%.

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
+ Coverage   16.11%   19.01%   +2.90%     
==========================================
  Files          30       33       +3     
  Lines        3482     3703     +221     
==========================================
+ Hits          561      704     +143     
- Misses       2821     2874      +53     
- Partials      100      125      +25

Flag	Coverage Δ
unittests	`19.01% <57.66%> (+2.90%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/controller/rollout/trafficrouting.go	`0.00% <0.00%> (ø)`
pkg/util/meta.go	`0.00% <0.00%> (ø)`
...ntroller/rollout/trafficrouting/ingress/ingress.go	`61.74% <61.74%> (ø)`
pkg/util/luamanager/lua.go	`64.58% <64.58%> (ø)`
...ntroller/rollout/trafficrouting/gateway/gateway.go	`53.27% <70.00%> (+8.27%)`	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

sonatype-lift · 2022-10-14T10:33:02Z

pkg/util/lua_configuration.go

+		if f.IsDir() {
+			return nil
+		}
+		data, err := ioutil.ReadFile(path)


G304: Potential file inclusion via variable

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-10-14T10:33:04Z

pkg/util/lua_configuration.go

+
+import (
+	"io/ioutil"
+	"k8s.io/klog/v2"


goimports: File is not goimports-ed

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-10-14T10:33:05Z

lua_configuration/trafficrouting_ingress/aliyun-alb.lua

@@ -0,0 +1,31 @@
+annotations = obj.annotations


💬 5 similar findings have been found in this PR

W111: setting non-standard global variable 'annotations'

🔎 Expand here to view all instances of this finding

File Path Line Number

lua_configuration/trafficrouting_ingress/aliyun-alb.lua 17

lua_configuration/trafficrouting_ingress/aliyun-mse.lua 1

lua_configuration/trafficrouting_ingress/aliyun-mse.lua 17

lua_configuration/trafficrouting_ingress/nginx.lua 1

lua_configuration/trafficrouting_ingress/nginx.lua 17

Visit the Lift Web Console to find more details in your report.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

@sonatype-lift ignore

I've recorded this as ignored for this pull request.
If you change your mind, just comment @sonatype-lift unignore.

sonatype-lift · 2022-10-14T10:33:07Z

lua_configuration/trafficrouting_ingress/aliyun-alb.lua

@@ -0,0 +1,31 @@
+annotations = obj.annotations
+annotations["alb.ingress.kubernetes.io/canary"] = "true"


💬 32 similar findings have been found in this PR

W112: mutating non-standard global variable 'annotations'

🔎 Expand here to view all instances of this finding

File Path Line Number

lua_configuration/trafficrouting_ingress/aliyun-alb.lua 3

lua_configuration/trafficrouting_ingress/aliyun-alb.lua 4

lua_configuration/trafficrouting_ingress/aliyun-alb.lua 5

lua_configuration/trafficrouting_ingress/aliyun-alb.lua 6

lua_configuration/trafficrouting_ingress/aliyun-alb.lua 7

lua_configuration/trafficrouting_ingress/aliyun-alb.lua 10

lua_configuration/trafficrouting_ingress/aliyun-alb.lua 20

lua_configuration/trafficrouting_ingress/aliyun-alb.lua 22

lua_configuration/trafficrouting_ingress/aliyun-alb.lua 25

lua_configuration/trafficrouting_ingress/aliyun-alb.lua 27

Showing 10 of 32 findings. Visit the Lift Web Console to see all.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

@sonatype-lift ignore

I've recorded this as ignored for this pull request.
If you change your mind, just comment @sonatype-lift unignore.

sonatype-lift · 2022-10-14T10:33:08Z

lua_configuration/trafficrouting_ingress/aliyun-alb.lua

@@ -0,0 +1,31 @@
+annotations = obj.annotations


💬 38 similar findings have been found in this PR

W113: accessing undefined variable 'obj'

🔎 Expand here to view all instances of this finding

File Path Line Number

lua_configuration/trafficrouting_ingress/aliyun-alb.lua 8

lua_configuration/trafficrouting_ingress/aliyun-alb.lua 10

lua_configuration/trafficrouting_ingress/aliyun-alb.lua 12

lua_configuration/trafficrouting_ingress/aliyun-alb.lua 14

lua_configuration/trafficrouting_ingress/aliyun-alb.lua 16

lua_configuration/trafficrouting_ingress/aliyun-alb.lua 18

lua_configuration/trafficrouting_ingress/aliyun-alb.lua 20

lua_configuration/trafficrouting_ingress/aliyun-alb.lua 22

lua_configuration/trafficrouting_ingress/aliyun-alb.lua 23

lua_configuration/trafficrouting_ingress/aliyun-alb.lua 25

Showing 10 of 38 findings. Visit the Lift Web Console to see all.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

@sonatype-lift ignore

I've recorded this as ignored for this pull request.
If you change your mind, just comment @sonatype-lift unignore.

sonatype-lift · 2022-10-17T11:32:30Z

pkg/util/lua_configuration.go

+			return nil
+		}
+		var data []byte
+		data, err = ioutil.ReadFile(path)


G304: Potential file inclusion via variable

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-10-17T11:32:33Z

pkg/util/lua_configuration.go

+
+func init() {
+	luaConfigurationList = map[string]string{}
+	filepath.Walk("./lua_configuration", func(path string, f os.FileInfo, err error) error {


SA4009: argument err is overwritten before first use

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-10-26T06:03:20Z

lua_configuration/trafficrouting_ingress/aliyun-alb.lua

@@ -0,0 +1,35 @@
+annotations = obj.annotations


💬 8 similar findings have been found in this PR

W111: setting non-standard global variable 'annotations'

🔎 Expand here to view all instances of this finding

File Path Line Number

lua_configuration/trafficrouting_ingress/aliyun-alb.lua 4

lua_configuration/trafficrouting_ingress/aliyun-alb.lua 21

lua_configuration/trafficrouting_ingress/aliyun-mse.lua 1

lua_configuration/trafficrouting_ingress/aliyun-mse.lua 4

lua_configuration/trafficrouting_ingress/aliyun-mse.lua 21

lua_configuration/trafficrouting_ingress/nginx.lua 1

lua_configuration/trafficrouting_ingress/nginx.lua 4

lua_configuration/trafficrouting_ingress/nginx.lua 21

Visit the Lift Web Console to find more details in your report.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-10-26T06:03:21Z

lua_configuration/trafficrouting_ingress/aliyun-alb.lua

+then
+    annotations = {}
+end
+annotations["alb.ingress.kubernetes.io/canary"] = "true"


💬 32 similar findings have been found in this PR

W112: mutating non-standard global variable 'annotations'

🔎 Expand here to view all instances of this finding

File Path Line Number

lua_configuration/trafficrouting_ingress/aliyun-alb.lua 7

lua_configuration/trafficrouting_ingress/aliyun-alb.lua 8

lua_configuration/trafficrouting_ingress/aliyun-alb.lua 9

lua_configuration/trafficrouting_ingress/aliyun-alb.lua 10

lua_configuration/trafficrouting_ingress/aliyun-alb.lua 11

lua_configuration/trafficrouting_ingress/aliyun-alb.lua 14

lua_configuration/trafficrouting_ingress/aliyun-alb.lua 24

lua_configuration/trafficrouting_ingress/aliyun-alb.lua 26

lua_configuration/trafficrouting_ingress/aliyun-alb.lua 29

lua_configuration/trafficrouting_ingress/aliyun-alb.lua 31

Showing 10 of 32 findings. Visit the Lift Web Console to see all.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-10-26T06:03:25Z

lua_configuration/trafficrouting_ingress/aliyun-alb.lua

@@ -0,0 +1,35 @@
+annotations = obj.annotations


💬 41 similar findings have been found in this PR

W113: accessing undefined variable 'obj'

🔎 Expand here to view all instances of this finding

File Path Line Number

lua_configuration/trafficrouting_ingress/aliyun-alb.lua 2

lua_configuration/trafficrouting_ingress/aliyun-alb.lua 12

lua_configuration/trafficrouting_ingress/aliyun-alb.lua 14

lua_configuration/trafficrouting_ingress/aliyun-alb.lua 16

lua_configuration/trafficrouting_ingress/aliyun-alb.lua 18

lua_configuration/trafficrouting_ingress/aliyun-alb.lua 20

lua_configuration/trafficrouting_ingress/aliyun-alb.lua 22

lua_configuration/trafficrouting_ingress/aliyun-alb.lua 24

lua_configuration/trafficrouting_ingress/aliyun-alb.lua 26

lua_configuration/trafficrouting_ingress/aliyun-alb.lua 27

Showing 10 of 41 findings. Visit the Lift Web Console to see all.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-11-08T07:42:16Z

pkg/util/luamanager/json.go

+	"encoding/json"
+	"errors"
+
+	"github.com/yuin/gopher-lua"


goimports: File is not goimports-ed

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-11-10T06:06:13Z

lua_configuration/trafficrouting_ingress/aliyun-alb.lua

@@ -0,0 +1,35 @@
+annotations = {}


💬 5 similar findings have been found in this PR

W111: setting non-standard global variable 'annotations'

🔎 Expand here to view all instances of this finding

File Path Line Number

lua_configuration/trafficrouting_ingress/aliyun-alb.lua 4

lua_configuration/trafficrouting_ingress/aliyun-mse.lua 1

lua_configuration/trafficrouting_ingress/aliyun-mse.lua 4

lua_configuration/trafficrouting_ingress/nginx.lua 1

lua_configuration/trafficrouting_ingress/nginx.lua 4

Visit the Lift Web Console to find more details in your report.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-11-10T06:06:14Z

lua_configuration/trafficrouting_ingress/aliyun-alb.lua

@@ -0,0 +1,35 @@
+annotations = {}
+if ( obj.annotations )


💬 5 similar findings have been found in this PR

W113: accessing undefined variable 'obj'

🔎 Expand here to view all instances of this finding

File Path Line Number

lua_configuration/trafficrouting_ingress/aliyun-alb.lua 4

lua_configuration/trafficrouting_ingress/aliyun-mse.lua 2

lua_configuration/trafficrouting_ingress/aliyun-mse.lua 4

lua_configuration/trafficrouting_ingress/nginx.lua 2

lua_configuration/trafficrouting_ingress/nginx.lua 4

Visit the Lift Web Console to find more details in your report.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-11-10T07:36:35Z

.lift.toml

@@ -0,0 +1,5 @@
+# Ignore results from vendor directories


Lift Configuration Added: Key: ignoreFiles

New value: vendor/
lua_configuration/

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>

pkg/controller/rollout/trafficrouting.go

furykerry · 2022-11-21T06:14:15Z

api/v1alpha1/rollout_types.go

@@ -141,7 +149,8 @@ type TrafficRouting struct {

 // IngressTrafficRouting configuration for ingress controller to control traffic routing
 type IngressTrafficRouting struct {
-	// ClassType refers to the class type of an `Ingress`, e.g. Nginx. Default is Nginx
+	// ClassType refers to the type of `Ingress`.
+	// current support nginx, aliyun-alb, aliyun-mse. default is nginx.


aliyun-mse is not in the lua_configuration

furykerry · 2022-11-21T09:14:37Z

pkg/controller/rollout/trafficrouting/ingress/ingress.go

+		return false, nil
+	}
+	// First, set canary route 0 weight.
+	newAnnotations, err := r.executeLuaForCanary(canaryIngress.Annotations, utilpointer.Int32(0), nil)


plz make sure that we use zero weight or -1 weight

Here is setting weight=0, because I want to set zero traffic to canary service first. And second delete the canary ingress.

furykerry · 2022-11-21T09:18:23Z

pkg/controller/rollout/trafficrouting/gateway/gateway.go

+func (r *gatewayController) buildDesiredHTTPRoute(rules []gatewayv1alpha2.HTTPRouteRule, weight *int32, matches []rolloutv1alpha1.HttpRouteMatch) []gatewayv1alpha2.HTTPRouteRule {
+	var desired []gatewayv1alpha2.HTTPRouteRule
+	// Only when finalize method parameter weight=-1, then we need to remove the canary route policy and restore to the original configuration
+	if weight != nil && *weight == -1 {


can we replace hard coded special value -1 with nil ?

Cannot, because step.weight=nil is valid parameter. weight=-1 specifically refers to the need to delete the canary configuration.

furykerry · 2022-11-21T09:20:51Z

pkg/util/luamanager/lua_test.go

+					end
+					for _,match in pairs(obj.matches)
+					do
+						if ( not (match or match.headers) )


plz include a test that use json in the lua script

Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>

furykerry

/lgtm

furykerry · 2022-11-22T03:21:55Z

/approve

kruise-bot · 2022-11-22T03:22:00Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furykerry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [furykerry]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kruise-bot requested review from FillZpp and furykerry September 22, 2022 11:47

kruise-bot added the size/L label Sep 22, 2022

kruise-bot added size/XXL and removed size/L labels Oct 13, 2022

zmberg changed the title ~~rollout support A/B Testing API~~ Implementing a generic Ingress based on Lua And A/B Testing Release Oct 13, 2022

zmberg force-pushed the optimize_traffic_scheduling branch 2 times, most recently from 235cb04 to 8da90a4 Compare October 14, 2022 10:24

sonatype-lift bot reviewed Oct 14, 2022

View reviewed changes

zmberg force-pushed the optimize_traffic_scheduling branch from 8da90a4 to 73ffa55 Compare October 17, 2022 11:24

sonatype-lift bot reviewed Oct 17, 2022

View reviewed changes

zmberg force-pushed the optimize_traffic_scheduling branch from 73ffa55 to 2205cb7 Compare October 18, 2022 08:12

zmberg force-pushed the optimize_traffic_scheduling branch from 2205cb7 to 7016e0a Compare October 26, 2022 05:55

sonatype-lift bot reviewed Oct 26, 2022

View reviewed changes

kruise-bot added the needs-rebase label Oct 31, 2022

zmberg force-pushed the optimize_traffic_scheduling branch 2 times, most recently from c8df109 to d0c7c6d Compare November 8, 2022 07:34

kruise-bot removed the needs-rebase label Nov 8, 2022

sonatype-lift bot reviewed Nov 8, 2022

View reviewed changes

zmberg force-pushed the optimize_traffic_scheduling branch 3 times, most recently from a86836d to d1b14f9 Compare November 9, 2022 06:37

zmberg closed this Nov 9, 2022

zmberg reopened this Nov 9, 2022

zmberg force-pushed the optimize_traffic_scheduling branch 2 times, most recently from f309156 to be0c76c Compare November 10, 2022 05:58

sonatype-lift bot reviewed Nov 10, 2022

View reviewed changes

zmberg force-pushed the optimize_traffic_scheduling branch from be0c76c to b8531f8 Compare November 10, 2022 07:26

sonatype-lift bot reviewed Nov 10, 2022

View reviewed changes

zmberg force-pushed the optimize_traffic_scheduling branch from b8531f8 to 1ff521d Compare November 10, 2022 09:18

zmberg mentioned this pull request Nov 14, 2022

How can i do canary release based on the http request header? #103

Open

kruise-bot added the needs-rebase label Nov 16, 2022

rollout support A/B Testing API

4724ba2

Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>

zmberg force-pushed the optimize_traffic_scheduling branch from 1ff521d to 015ab3f Compare November 17, 2022 09:22

kruise-bot removed the needs-rebase label Nov 17, 2022

furykerry reviewed Nov 17, 2022

View reviewed changes

pkg/controller/rollout/trafficrouting.go Outdated Show resolved Hide resolved

zmberg force-pushed the optimize_traffic_scheduling branch 2 times, most recently from 9a4e9aa to 67714bd Compare November 21, 2022 06:53

furykerry reviewed Nov 21, 2022

View reviewed changes

Implementing a generic Ingress based on Lua

aab4903

Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>

zmberg force-pushed the optimize_traffic_scheduling branch from 67714bd to aab4903 Compare November 22, 2022 02:27

furykerry reviewed Nov 22, 2022

View reviewed changes

kruise-bot assigned furykerry Nov 22, 2022

kruise-bot added the lgtm label Nov 22, 2022

kruise-bot added the approved label Nov 22, 2022

kruise-bot merged commit 0c54037 into openkruise:master Nov 22, 2022

zmberg deleted the optimize_traffic_scheduling branch December 20, 2022 06:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implementing a generic Ingress based on Lua And A/B Testing Release #86

Implementing a generic Ingress based on Lua And A/B Testing Release #86

zmberg commented Sep 22, 2022 •

edited

Loading

codecov-commenter commented Sep 22, 2022 •

edited

Loading

sonatype-lift bot Oct 14, 2022

sonatype-lift bot Oct 14, 2022

sonatype-lift bot Oct 14, 2022

zmberg Oct 17, 2022

sonatype-lift bot Oct 17, 2022

sonatype-lift bot Oct 14, 2022

zmberg Oct 17, 2022

sonatype-lift bot Oct 17, 2022

sonatype-lift bot Oct 14, 2022

zmberg Oct 17, 2022

sonatype-lift bot Oct 17, 2022

sonatype-lift bot Oct 17, 2022

sonatype-lift bot Oct 17, 2022

sonatype-lift bot Oct 26, 2022

sonatype-lift bot Oct 26, 2022

sonatype-lift bot Oct 26, 2022

sonatype-lift bot Nov 8, 2022

sonatype-lift bot Nov 10, 2022

sonatype-lift bot Nov 10, 2022

sonatype-lift bot Nov 10, 2022

furykerry Nov 21, 2022

furykerry Nov 21, 2022

zmberg Nov 22, 2022 •

edited

Loading

furykerry Nov 21, 2022

zmberg Nov 22, 2022

furykerry Nov 21, 2022

furykerry left a comment

furykerry commented Nov 22, 2022

kruise-bot commented Nov 22, 2022

Command	Usage
`@sonatype-lift ignore`	Leave out the above finding from this PR
`@sonatype-lift ignoreall`	Leave out all the existing findings from this PR
`@sonatype-lift exclude <file\|issue\|path\|tool>`	Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file

		@@ -0,0 +1,31 @@
		annotations = obj.annotations
		annotations["alb.ingress.kubernetes.io/canary"] = "true"

Implementing a generic Ingress based on Lua And A/B Testing Release #86

Implementing a generic Ingress based on Lua And A/B Testing Release #86

Conversation

zmberg commented Sep 22, 2022 • edited Loading

Ⅰ. Describe what this PR does

codecov-commenter commented Sep 22, 2022 • edited Loading

Codecov Report

sonatype-lift bot Oct 14, 2022

Choose a reason for hiding this comment

sonatype-lift bot Oct 14, 2022

Choose a reason for hiding this comment

sonatype-lift bot Oct 14, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonatype-lift bot Oct 17, 2022

Choose a reason for hiding this comment

sonatype-lift bot Oct 14, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonatype-lift bot Oct 17, 2022

Choose a reason for hiding this comment

sonatype-lift bot Oct 14, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonatype-lift bot Oct 17, 2022

Choose a reason for hiding this comment

sonatype-lift bot Oct 17, 2022

Choose a reason for hiding this comment

sonatype-lift bot Oct 17, 2022

Choose a reason for hiding this comment

sonatype-lift bot Oct 26, 2022

Choose a reason for hiding this comment

sonatype-lift bot Oct 26, 2022

Choose a reason for hiding this comment

sonatype-lift bot Oct 26, 2022

Choose a reason for hiding this comment

sonatype-lift bot Nov 8, 2022

Choose a reason for hiding this comment

sonatype-lift bot Nov 10, 2022

Choose a reason for hiding this comment

sonatype-lift bot Nov 10, 2022

Choose a reason for hiding this comment

sonatype-lift bot Nov 10, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zmberg Nov 22, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

furykerry left a comment

Choose a reason for hiding this comment

furykerry commented Nov 22, 2022

kruise-bot commented Nov 22, 2022

zmberg commented Sep 22, 2022 •

edited

Loading

codecov-commenter commented Sep 22, 2022 •

edited

Loading

zmberg Nov 22, 2022 •

edited

Loading