Fix: ImagePullJob timeout setting is not effective when it is greater than 1800 #1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1874 +/- ##
==========================================
+ Coverage 47.91% 50.93% +3.01%
==========================================
Files 162 192 +30
Lines 23491 24953 +1462
==========================================
+ Hits 11256 12710 +1454
+ Misses 11014 10939 -75
- Partials 1221 1304 +83
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
89e42b9 to
2231201
Compare
furykerry
reviewed
Jan 3, 2025
pkg/webhook/imagepulljob/validating/imagepulljob_create_update_handler.go
Outdated
Show resolved
Hide resolved
2231201 to
2c621f3
Compare
furykerry
reviewed
Jan 7, 2025
| if job.Spec.PullPolicy != nil && job.Spec.PullPolicy.TimeoutSeconds != nil && | ||
| int64(*job.Spec.PullPolicy.TimeoutSeconds) > defaultActiveDeadlineSecondsForNever { | ||
|
|
||
| var ret = int64(*job.Spec.PullPolicy.TimeoutSeconds) |
There was a problem hiding this comment.
why not use the package 'k8s.io/utils/pointer'
| if job.Spec.PullPolicy != nil && job.Spec.PullPolicy.TimeoutSeconds != nil && | ||
| int64(*job.Spec.PullPolicy.TimeoutSeconds) > defaultActiveDeadlineSecondsForNever { | ||
|
|
||
| var ret = int64(*job.Spec.PullPolicy.TimeoutSeconds) |
There was a problem hiding this comment.
why int64, it seems that TimeoutSeconds is of *int32 type
There was a problem hiding this comment.
because activeDeadlineSeconds is *int64.
… than 1800 Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
2c621f3 to
92c8627
Compare
|
/approve |
furykerry
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… than 1800
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews