define partition as number of non-updated pods should be reversed #1819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abner-1 <yuanyuxing.yyx@alibaba-inc.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1819 +/- ##
==========================================
+ Coverage 47.91% 49.99% +2.07%
==========================================
Files 162 192 +30
Lines 23491 24641 +1150
==========================================
+ Hits 11256 12319 +1063
- Misses 11014 11047 +33
- Partials 1221 1275 +54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
furykerry
reviewed
Nov 6, 2024
| if rollingUpdateStrategy == nil || rollingUpdateStrategy.UnorderedUpdate == nil { | ||
| var indexes []int | ||
| for target := len(replicas) - 1; target >= updateMin; target-- { | ||
| for target := len(replicas) - 1; target >= updateMin && len(indexes) < maxUpdate; target-- { |
There was a problem hiding this comment.
is it necessary to add the maxUpdate comparison here , since maxUpdate will be checked in L72
There was a problem hiding this comment.
In L41, we return indexes and will not go to the L72.
furykerry
pushed a commit
to furykerry/kruise
that referenced
this pull request
Feb 8, 2025
…enkruise#1819) Signed-off-by: Abner-1 <yuanyuxing.yyx@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
define partition as number of non-updated pods should be reversed
Ⅱ. Does this pull request fix one issue?
fixes #1813
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews