an error will be returned by workloadspread webhook when `getObjectOf…

…` pod's owner failed; prevent WorkloadSpread e2e panic

Signed-off-by: AiRanthem <zhongtianyun.zty@alibaba-inc.com>

pkg/util/workloadspread/workloadspread.go

@@ -224,10 +224,16 @@ func (h *Handler) HandlePodCreation(pod *corev1.Pod) (skip bool, err error) {
 			continue
 		}
 		// determine if the reference of workloadSpread and pod is equal
-		if h.isReferenceEqual(ws.Spec.TargetReference, ref, pod.Namespace) {
+		if ok, err := h.isReferenceEqual(ws.Spec.TargetReference, ref, pod.Namespace); ok {
 			matchedWS = &ws
 			// pod has at most one matched workloadSpread
 			break
+		} else if err != nil {
+			klog.ErrorS(err, "failed to determine whether workloadspread refers pod's owner")
+			if errors.IsNotFound(err) {
+				klog.ErrorS(err, "pod owner not found")
+				return true, err
+			}
 		}
 	}
 	// not found matched workloadSpread
@@ -687,35 +693,34 @@ func (h *Handler) getSuitableSubset(subsetStatuses []appsv1alpha1.WorkloadSpread
 	return nil
 }
 
-func (h *Handler) isReferenceEqual(target *appsv1alpha1.TargetReference, owner *metav1.OwnerReference, namespace string) bool {
+func (h *Handler) isReferenceEqual(target *appsv1alpha1.TargetReference, owner *metav1.OwnerReference, namespace string) (bool, error) {
 	if owner == nil {
-		return false
+		return false, nil
 	}
 
 	targetGv, err := schema.ParseGroupVersion(target.APIVersion)
 	if err != nil {
 		klog.ErrorS(err, "parse TargetReference apiVersion failed", "apiVersion", target.APIVersion)
-		return false
+		return false, err
 	}
 
 	ownerGv, err := schema.ParseGroupVersion(owner.APIVersion)
 	if err != nil {
 		klog.ErrorS(err, "parse OwnerReference apiVersion failed", "apiVersion", owner.APIVersion)
-		return false
+		return false, err
 	}
 
 	if targetGv.Group == ownerGv.Group && target.Kind == owner.Kind && target.Name == owner.Name {
-		return true
+		return true, nil
 	}
 
 	if match, err := matchReference(owner); err != nil || !match {
-		return false
+		return false, err
 	}
 
 	ownerObject, err := h.getObjectOf(owner, namespace)
 	if err != nil {
-		klog.ErrorS(err, "Failed to get owner object", "owner", owner)
-		return false
+		return false, err
 	}
 
 	return h.isReferenceEqual(target, metav1.GetControllerOfNoCopy(ownerObject), namespace)

pkg/util/workloadspread/workloadspread_test.go

@@ -53,6 +53,13 @@ import (
 var (
 	scheme *runtime.Scheme
 
+	cloneSetDemo = &appsv1alpha1.CloneSet{
+		ObjectMeta: metav1.ObjectMeta{
+			Name:      "cloneset-test",
+			Namespace: "default",
+		},
+	}
+
 	podDemo = &corev1.Pod{
 		ObjectMeta: metav1.ObjectMeta{
 			Name:        "test-pod-1",
@@ -1088,7 +1095,7 @@ func TestWorkloadSpreadMutatingPod(t *testing.T) {
 			expectWS := cs.expectWorkloadSpread()
 			podExpect := cs.expectPod()
 			fakeClient := fake.NewClientBuilder().WithScheme(scheme).
-				WithObjects(workloadSpreadIn).WithStatusSubresource(&appsv1alpha1.WorkloadSpread{}).Build()
+				WithObjects(workloadSpreadIn, cloneSetDemo).WithStatusSubresource(&appsv1alpha1.WorkloadSpread{}).Build()
 			handler := NewWorkloadSpreadHandler(fakeClient)
 
 			var err error
@@ -1260,7 +1267,7 @@ func TestIsReferenceEqual(t *testing.T) {
 	for _, cs := range cases {
 		t.Run(cs.name, func(t *testing.T) {
 			h := Handler{fake.NewClientBuilder().Build()}
-			if h.isReferenceEqual(cs.getTargetRef(), cs.getOwnerRef(), "") != cs.expectEqual {
+			if ok, _ := h.isReferenceEqual(cs.getTargetRef(), cs.getOwnerRef(), ""); ok != cs.expectEqual {
 				t.Fatalf("isReferenceEqual failed")
 			}
 		})
@@ -1400,7 +1407,7 @@ func TestIsReferenceEqual2(t *testing.T) {
 			handler := &Handler{Client: cli}
 			workloadsInWhiteListInitialized = false
 			initializeWorkloadsInWhiteList(cli)
-			result := handler.isReferenceEqual(&ref, metav1.GetControllerOf(pod), pod.GetNamespace())
+			result, _ := handler.isReferenceEqual(&ref, metav1.GetControllerOf(pod), pod.GetNamespace())
 			if result != cs.Expect {
 				t.Fatalf("got unexpected result")
 			}