69 update geodata structure #81
Conversation
| @@ -14,13 +14,6 @@ | |||
| legend: | |||
| - type: "colormap" | |||
| color: "blue" | |||
| metadata: | |||
There was a problem hiding this comment.
Hi, these metadata are moved to GeoData.yml because they are about geojson not attributes. Now no metadata are left in MapLayers.yml. Should we show on frontend geoMetadata from GeoData.yml instead of them? Or it doesn't matter for now? Or I can put:
description: "Sample data created just for this purpose. Do not represent the reality in any time."
updateFrequency: "never"
unit: "n/a"
dataRetrievalDescription: "Data was randomly created."
also into MapLayers.yml metadata to have example there.
There was a problem hiding this comment.
@bariela can you maybe help here? To me some of the metadata are connected with geodata, and some might be connected with map layer
There was a problem hiding this comment.
@bariela Hi, can you please check this so we can merge it? Thanks a lot
There was a problem hiding this comment.
Hi,
each data/metadata should be only in one place and before returning to frontend, they should all be merged into one object. And yes, only some metadata of are linked with geoData. Did this answer the question?
There was a problem hiding this comment.
@MartinJurcoGlina @bariela Hi, I refactored this one after consultation with Daniela, now its returning geoMetadata in Maplayers metadata. It is working but I can't see, when I click on info icon the metadata. Sorry I don't have time to fix this, but it should be easy. I will leave it to you. Also function failed in pipeline but I don't know why. I think Daniela had some problem with them too.
| featureIds: [{property: "name", values: ["Bratislavský", "Trnavský", "Trenčiansky", "Nitriansky", "Žilinský", "Banskobystrický", "Prešovský", "Košický"]}, { property: "fullname", values: ["Bratislavský kraj", "Trnavský kraj", "Trenčiansky kraj", "Nitriansky kraj", "Žilinský kraj", "Banskobystrický kraj", "Prešovský kraj", "Košický kraj"]}] | ||
| attributeIds: [] | ||
| geometryDataTypes: "regions" | ||
| geoMetadata: |
There was a problem hiding this comment.
Should this be called geoMetadata or metadata here? On frontend I will then return geoMetadata for sure, otherwise these will mess with each other.
There was a problem hiding this comment.
metadata, according to the task
api/src/actions/mapLayersActions.js
Outdated
| })); | ||
| return { ...layer, layers: sublayers }; | ||
| } | ||
|
|
||
| return { | ||
| ...layer, | ||
| geoJSONUrl: geoJSONUrls[layer.geoReferenceId], | ||
| geoDataUrl: geoDataUrls[layer.geoReferenceId], | ||
| geoMetadata: geoMetadata[layer.geoReferenceId], |
There was a problem hiding this comment.
I just return geoMetadata in static layers. Showing them somewhere is not part of this task, correct?
There was a problem hiding this comment.
just check that nothing is broken by this in frontend
There was a problem hiding this comment.
looks OK on the frontend, just no info icon is shown because we have no mapLayers metadata there.
Description
MapLayer table is updated and is now storing geoMetadata in metadata property and returns it on frontend and its also returning format. You should see metadata on frontend, when you click on info icon.
this branch is parent for: #84
Motivation and Context
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist: