Skip to content
This repository has been archived by the owner on Aug 1, 2024. It is now read-only.

geodata with only apiUrl for already existing path #142

Merged
merged 3 commits into from
Aug 2, 2022
Merged

Conversation

bariela
Copy link
Collaborator

@bariela bariela commented Jul 19, 2022

Description

Removed condition for collectionName in geodata config, so the geodata can be defined by "apiUrl" to already existing collection and data by just url

Motivation and Context

Came across usecase, where I've got existing db collection

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked to ensure that there aren't other open Pull Requests for the same update/change.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bariela bariela requested a review from srezacova July 26, 2022 12:35
@srezacova
Copy link
Collaborator


Hi, is it necessary to have this line here now? If data.apiUrl exist, we have already set it. If not, undefined will be returned even without this line.

@bariela
Copy link
Collaborator Author

bariela commented Aug 2, 2022

Hi, is it necessary to have this line here now? If data.apiUrl exist, we have already set it. If not, undefined will be returned even without this line.

true, good catch!

@srezacova srezacova merged commit bd3dbed into main Aug 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants