Skip to content
This repository has been archived by the owner on Aug 1, 2024. It is now read-only.

set failing code for url-loader, if data fetching fails #128

Merged
merged 1 commit into from
May 13, 2022

Conversation

bariela
Copy link
Collaborator

@bariela bariela commented May 11, 2022

Description

url-loader service always exited with code 0, even when it failed to fetch data,
setting exitCode to 1 if any of data is not loaded, but still attempting all of them

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked to ensure that there aren't other open Pull Requests for the same update/change.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bariela bariela requested a review from MartinJurcoGlina May 11, 2022 14:14
@MartinJurcoGlina MartinJurcoGlina merged commit b84f875 into main May 13, 2022
@MartinJurcoGlina MartinJurcoGlina deleted the fail-url-loader branch May 13, 2022 14:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants