-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: ASTE: An artificial solver testing environment for partitioned coupling with preCICE #7127
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: 🟡 License found: |
Hi @asalmgren, @hverhelst how is your review going? |
I won’t be able to start this until late September or early October.
A
Ann Almgren
Senior Scientist; Dept. Head, Applied Mathematics
Pronouns: she/her/hers
…On Fri, Aug 30, 2024 at 2:15 AM Patrick Diehl ***@***.***> wrote:
Hi @asalmgren <https://github.com/asalmgren>, @hverhelst
<https://github.com/hverhelst> how is your review going?
—
Reply to this email directly, view it on GitHub
<#7127 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACRE6YQ7HCPX2UCCHIS4DZLZUAZ2XAVCNFSM6AAAAABM5HDOMCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRQGYYDKMRQGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Review checklist for @hverhelstConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
I had some questions and published an issue here |
@editorialbot commands |
Hello @asalmgren, here are the things you can ask me to do:
|
Review checklist for @asalmgrenConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@editorialbot generate pdf |
Hi @asalmgren how is your review going? |
Hi @diehlpk , my review is finished, I would accept the software for publication. |
Hi @asalmgren how is your review going? When do you think you can finish it? |
1 similar comment
Hi @asalmgren how is your review going? When do you think you can finish it? |
Regarding the community guidelines -- I do not see a CONTRIBUTING.md or similar file that gives guidance to anyone wanting to contribute to the software or report bugs. I do not see this information in the README file either. |
Regarding the installation instructions -- the dependencies are clearly identified. However, if I follow the "Building and Installation" instructions I get the following error message. I'm assuming that I need to have built precice before I can build aste but that should be clearly stated in the "Building and installation" sections of the instructions. CMake Error at CMakeLists.txt:24 (find_package): Could not find a package configuration file provided by "precice"
Add the installation prefix of "precice" to CMAKE_PREFIX_PATH or set |
Done! version is now v.3.3.0 |
@davidscn could you please update the title on darus to match the one of the paper? Currently, the title is ASTE Version v3.3.0. |
The version set here has an additional dot after the v as opposed to the actual version v3.3.0
Sorry, I solely focused on the authors and thought it would be ambiguous to use the same for the data. I contacted DaRUS and asked for fix. The fix is now published as a new (major) version of the data set. The DOI is DOI: 10.18419/darus-4562 |
@editorialbot set v3.3.0 as version |
Done! version is now v3.3.0 |
@editorialbot set 10.18419/darus-4562 as archive |
Done! archive is now 10.18419/darus-4562 |
@editorialbot recommend-accept |
|
|
👋 @openjournals/csism-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#6127, then you can now move forward with accepting the submission by compiling again with the command |
@diehlpk Thank you very much for your support and effort! |
@davidscn - As track chair, I've suggested some changes in precice/aste#218 - please merge this or let me know what you disagree with, then we can proceed. |
@editorialbot recommend-accept |
|
|
👋 @openjournals/csism-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#6139, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🦋🦋🦋 👉 Bluesky post for this paper 👈 🦋🦋🦋 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations to @davidscn (David Schneider) and co-authors on your publication!! And thanks to @asalmgren and @hverhelst for reviewing, and to @diehlpk for editing! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Thanks again to everyone for your help and contributions! |
Submitting author: @davidscn (David Schneider)
Repository: https://github.com/precice/aste
Branch with paper.md (empty if default branch): paper
Version: v3.3.0
Editor: @diehlpk
Reviewers: @asalmgren, @hverhelst
Archive: 10.18419/darus-4562
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@asalmgren & @hverhelst, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @diehlpk know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @hverhelst
📝 Checklist for @asalmgren
The text was updated successfully, but these errors were encountered: