Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8258749: Remove Dynalink tests from Standalone Nashorn #10

Merged
merged 1 commit into from
Dec 30, 2020

Conversation

szegedi
Copy link
Collaborator

@szegedi szegedi commented Dec 20, 2020

Dynalink tests have been moved into mainline jtreg test suites in the JDK project, they need not exist anymore in the standalone Nashorn project.

Tests that exercise Nashorn's usage of Dynalink obviously need to stay as they couldn't be moved to JDK due to lack of Nashorn in it.

An initial driver for this was that I was compiling Standalone Nashorn with Java 11 to see if it's possible, and it all worked fine except for two tests failing, one of them being a test for a Dynalink bug fixed in Java 12. There's no need for the Nashorn project to repeat Dynalink JDK tests.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • JDK-8258749: Remove Dynalink tests from Standalone Nashorn

Download

$ git fetch https://git.openjdk.java.net/nashorn pull/10/head:pull/10
$ git checkout pull/10

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 20, 2020

👋 Welcome back attila! A progress list of the required criteria for merging this PR into main will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 20, 2020
@szegedi szegedi merged commit 91b4794 into openjdk:main Dec 30, 2020
@szegedi szegedi deleted the dyna-un-link branch December 30, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant