8258749: Remove Dynalink tests from Standalone Nashorn #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynalink tests have been moved into mainline jtreg test suites in the JDK project, they need not exist anymore in the standalone Nashorn project.
Tests that exercise Nashorn's usage of Dynalink obviously need to stay as they couldn't be moved to JDK due to lack of Nashorn in it.
An initial driver for this was that I was compiling Standalone Nashorn with Java 11 to see if it's possible, and it all worked fine except for two tests failing, one of them being a test for a Dynalink bug fixed in Java 12. There's no need for the Nashorn project to repeat Dynalink JDK tests.
Progress
Issue
Download
$ git fetch https://git.openjdk.java.net/nashorn pull/10/head:pull/10
$ git checkout pull/10