Skip to content

Commit

Permalink
Release 15.5
Browse files Browse the repository at this point in the history
  • Loading branch information
@szegedi
szegedi committed Dec 15, 2024
1 parent 5e78947 commit de13268
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
5 changes: 4 additions & 1 deletion CHANGELOG.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ No code changes, but the artifacts published on Maven Central are now compiled w
-----------------
[`#17`](https://github.com/openjdk/nashorn/pull/17) [`JDK-8283339`](https://bugs.openjdk.java.net/browse/JDK-8283339) TypeError: undefined is not an Object after JDK-8240299

15.5 (unreleased)
15.5 (2024.12.15)
-----------------
[`#18`](https://github.com/openjdk/nashorn/pull/18) [`JDK-8294560`](https://bugs.openjdk.java.net/browse/JDK-8294560) assertion raised in newBuiltinSwitchPoint

[`#19`](https://github.com/openjdk/nashorn/pull/19) [`JDK-8343449`](https://bugs.openjdk.java.net/browse/JDK-8343449) Nashorn method handle debug logging breaks with log4j-jul

2 changes: 1 addition & 1 deletion README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ Nashorn-related documents last published by Oracle with Java 14:

Getting Started
===============
Latest version of Nashorn is 15.4, available from [Maven Central](https://search.maven.org/artifact/org.openjdk.nashorn/nashorn-core/15.4/jar). You can check the [change log](CHANGELOG.md) to see what's new.
Latest version of Nashorn is 15.5, available from [Maven Central](https://search.maven.org/artifact/org.openjdk.nashorn/nashorn-core/15.5/jar). You can check the [change log](CHANGELOG.md) to see what's new.

Nashorn is a JPMS module, so make sure it and its transitive dependencies (Nashorn depends on several ASM JARs) are on your application's module path, or appropriately added to a module layer, or otherwise configured as modules.

Expand Down
4 changes: 2 additions & 2 deletions make/nashorn/project.properties
View file
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ javadoc.option=\
nashorn.target.java.version=11

# nashorn version information
nashorn.version=15.4
nashorn.fullversion=15.4
nashorn.version=15.5
nashorn.fullversion=15.5
nashorn.product.name=OpenJDK Nashorn

# This directory is removed when the project is cleaned:
Expand Down

4 comments on commit de13268

@kangarko
Copy link

@kangarko kangarko commented on de13268 Dec 16, 2024 •
edited by bridgekeeper bot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@szegedi

Unfortunately, this release appears to be broken when loaded on the Velocity server software: https://papermc.io/downloads/velocity

[01:00:24 ERROR]: java.lang.ExceptionInInitializerError
[01:00:24 ERROR]:       at org.openjdk.nashorn.internal.runtime.linker.Bootstrap.<clinit>(Bootstrap.java:68)
[01:00:24 ERROR]:       at org.openjdk.nashorn.internal.runtime.Context.<init>(Context.java:655)
[01:00:24 ERROR]:       at org.openjdk.nashorn.internal.runtime.Context.<init>(Context.java:585)
[01:00:24 ERROR]:       at org.openjdk.nashorn.api.scripting.NashornScriptEngine.lambda$new$0(NashornScriptEngine.java:126)
[01:00:24 ERROR]:       at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
[01:00:24 ERROR]:       at org.openjdk.nashorn.api.scripting.NashornScriptEngine.<init>(NashornScriptEngine.java:124)
[01:00:24 ERROR]:       at org.openjdk.nashorn.api.scripting.NashornScriptEngineFactory.getScriptEngine(NashornScriptEngineFactory.java:152)
[01:00:24 ERROR]:       at java.scripting/javax.script.ScriptEngineManager.lambda$getEngineBy$2(ScriptEngineManager.java:237)
[01:00:24 ERROR]:       at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
[01:00:24 ERROR]:       at java.base/java.util.stream.StreamSpliterators$WrappingSpliterator.tryAdvance(StreamSpliterators.java:300)
[01:00:24 ERROR]:       at java.base/java.util.stream.Streams$ConcatSpliterator.tryAdvance(Streams.java:723)
[01:00:24 ERROR]:       at java.base/java.util.stream.ReferencePipeline.forEachWithCancel(ReferencePipeline.java:129)
[01:00:24 ERROR]:       at java.base/java.util.stream.AbstractPipeline.copyIntoWithCancel(AbstractPipeline.java:527)
[01:00:24 ERROR]:       at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:513)
[01:00:24 ERROR]:       at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
[01:00:24 ERROR]:       at java.base/java.util.stream.FindOps$FindOp.evaluateSequential(FindOps.java:150)
[01:00:24 ERROR]:       at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
[01:00:24 ERROR]:       at java.base/java.util.stream.ReferencePipeline.findFirst(ReferencePipeline.java:647)
[01:00:24 ERROR]:       at java.scripting/javax.script.ScriptEngineManager.getEngineBy(ScriptEngineManager.java:246)
[01:00:24 ERROR]:       at java.scripting/javax.script.ScriptEngineManager.getEngineByName(ScriptEngineManager.java:185)[01:00:24 ERROR]:       at org.mineacademy.fo.model.JavaScriptExecutor.<clinit>(JavaScriptExecutor.java:48)
[01:00:24 ERROR]:       at org.mineacademy.fo.platform.VelocityPlugin.onProxyInitialization(VelocityPlugin.java:238)
[01:00:24 ERROR]:       at org.mineacademy.fo.platform.Lmbda$1.execute(Unknown Source)
[01:00:24 ERROR]:       at com.velocitypowered.proxy.event.UntargetedEventHandler$VoidHandler.lambda$buildHandler$0(UntargetedEventHandler.java:56)
[01:00:24 ERROR]:       at com.velocitypowered.proxy.event.VelocityEventManager.fire(VelocityEventManager.java:676)
[01:00:24 ERROR]:       at com.velocitypowered.proxy.event.VelocityEventManager.lambda$fire$5(VelocityEventManager.java:541)
[01:00:24 ERROR]:       at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
[01:00:24 ERROR]:       at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
[01:00:24 ERROR]:       at java.base/java.lang.Thread.run(Thread.java:1583)
[01:00:24 ERROR]: Caused by: java.lang.NullPointerException: Cannot invoke "org.openjdk.nashorn.internal.runtime.ScriptObject.getContext()" because "global" is null
[01:00:24 ERROR]:       at org.openjdk.nashorn.internal.runtime.Context.getContext(Context.java:1377)
[01:00:24 ERROR]:       at org.openjdk.nashorn.internal.runtime.Context.getContextTrusted(Context.java:1299)
[01:00:24 ERROR]:       at org.openjdk.nashorn.internal.runtime.Context.getContext(Context.java:453)
[01:00:24 ERROR]:       at org.openjdk.nashorn.internal.lookup.MethodHandleFactory.<clinit>(MethodHandleFactory.java:61)[01:00:24 ERROR]:       ... 29 more
[01:00:24 INFO]: java.lang.NoClassDefFoundError: Could not initialize class org.openjdk.nashorn.internal.runtime.linker.Bootstrap
[01:00:24 INFO]:        at org.openjdk.nashorn.internal.runtime.Context.<init>(Context.java:655)
[01:00:24 INFO]:        at org.openjdk.nashorn.internal.runtime.Context.<init>(Context.java:585)
[01:00:24 INFO]:        at org.openjdk.nashorn.api.scripting.NashornScriptEngine.lambda$new$0(NashornScriptEngine.java:126)
[01:00:24 INFO]:        at org.openjdk.nashorn.api.scripting.NashornScriptEngine.<init>(NashornScriptEngine.java:124)
[01:00:24 INFO]:        at org.openjdk.nashorn.api.scripting.NashornScriptEngineFactory.getScriptEngine(NashornScriptEngineFactory.java:152)
[01:00:24 INFO]:        at org.mineacademy.fo.model.JavaScriptExecutor.<clinit>(JavaScriptExecutor.java:102)
[01:00:24 INFO]:        at org.mineacademy.fo.platform.VelocityPlugin.onProxyInitialization(VelocityPlugin.java:238)
[01:00:24 INFO]:        at org.mineacademy.fo.platform.Lmbda$1.execute(Unknown Source)
[01:00:24 INFO]:        at com.velocitypowered.proxy.event.UntargetedEventHandler$VoidHandler.lambda$buildHandler$0(UntargetedEventHandler.java:56)
[01:00:24 INFO]:        at com.velocitypowered.proxy.event.VelocityEventManager.fire(VelocityEventManager.java:676)
[01:00:24 INFO]:        at com.velocitypowered.proxy.event.VelocityEventManager.lambda$fire$5(VelocityEventManager.java:541)
[01:00:24 INFO]: java.lang.ExceptionInInitializerError: Exception java.lang.ExceptionInInitializerError [in thread "VelocityControl - Task Executor #0"]
[01:00:24 INFO]:        at org.openjdk.nashorn.internal.runtime.linker.Bootstrap.<clinit>(Bootstrap.java:68)
[01:00:24 INFO]:        at org.openjdk.nashorn.internal.runtime.Context.<init>(Context.java:655)
[01:00:24 INFO]:        at org.openjdk.nashorn.internal.runtime.Context.<init>(Context.java:585)
[01:00:24 INFO]:        at org.openjdk.nashorn.api.scripting.NashornScriptEngine.lambda$new$0(NashornScriptEngine.java:126)
[01:00:24 INFO]:        at org.openjdk.nashorn.api.scripting.NashornScriptEngine.<init>(NashornScriptEngine.java:124)
[01:00:24 INFO]:        at org.openjdk.nashorn.api.scripting.NashornScriptEngineFactory.getScriptEngine(NashornScriptEngineFactory.java:152)
[01:00:24 INFO]:        at org.mineacademy.fo.model.JavaScriptExecutor.<clinit>(JavaScriptExecutor.java:48)
[01:00:24 INFO]:        at org.mineacademy.fo.platform.VelocityPlugin.onProxyInitialization(VelocityPlugin.java:238)
[01:00:24 INFO]:        at org.mineacademy.fo.platform.Lmbda$1.execute(Unknown Source)
[01:00:24 INFO]:        at com.velocitypowered.proxy.event.UntargetedEventHandler$VoidHandler.lambda$buildHandler$0(UntargetedEventHandler.java:56)
[01:00:24 INFO]:        at com.velocitypowered.proxy.event.VelocityEventManager.fire(VelocityEventManager.java:676)
[01:00:24 INFO]:        at com.velocitypowered.proxy.event.VelocityEventManager.lambda$fire$5(VelocityEventManager.java:541)

Would you prefer we continue at bugs.openjdk.com or can a hotfix be made, please? We've been waiting for the previous log4j debug log fix for months in hopes this release will boot. Thanks.

@szegedi
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can reproduce this easily, will definitely fix it today.

@szegedi
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kangarko can you perhaps try to substitute the Nashorn's core JAR with this one I just built from an intermediate fix: https://www.dropbox.com/scl/fi/h93urg1zo6j5a9fm2dgtl/nashorn-core-15.5.jar?rlkey=vjs7p8yi3lnarivad7pj7irmv&dl=0
I'd like to validate it first. (If you're skeptical about getting a binary from a Dropbox link, you can also build from source at https://github.com/szegedi/nashorn/tree/fix-logging-2).

@kangarko
Copy link

@kangarko kangarko commented on de13268 Dec 16, 2024 •
edited by bridgekeeper bot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@szegedi Works now!! You're a champion thank you!

Please sign in to comment.