Removed CSR mscratchcsw. #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oystein Knauserud <Oystein.Knauserud@silabs.com>
Silabs-ArjanB
requested changes
Aug 31, 2023
| @@ -4487,22 +4487,6 @@ ifelse(eval(CLIC != 0), 1, [[[ | |||
| lsb: 0 | |||
| ]]]) | |||
There was a problem hiding this comment.
Not okay to remove this from the yaml file as we try to have the same yaml between 40x and 40s. The CSR should be excluded for non-CLIC and if user mode is not supported.
Only this file should get merged to the 40S, not the other files
There was a problem hiding this comment.
Added mscratchcsw back in and guarded with CLIC and UMODE.
rtl/cv32e40x_i_decoder.sv
Outdated
| // The mscratchcsw[l] CSRs are only accessible using CSRRW with neither rd nor rs1 set to x0 | ||
| if ((instr_rdata_i[31:20] == CSR_MSCRATCHCSW) || (instr_rdata_i[31:20] == CSR_MSCRATCHCSWL)) begin | ||
| // The mscratchcswl CSR is only accessible using CSRRW with neither rd nor rs1 set to x0 | ||
| if ((instr_rdata_i[31:20] == CSR_MSCRATCHCSWL)) begin |
There was a problem hiding this comment.
Remove double brackets
Signed-off-by: Oystein Knauserud <Oystein.Knauserud@silabs.com>
Silabs-ArjanB
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.