Added usage of 'csr_next_value' function for almost all CSRs. #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All CSR instances now use MASK and RESET_VAL. Some CSRs that are dependent on other CSR next values (mnxti, mscratchcsw[l]) do not use the function. Neither does the read-only CSRs that rely on inputs not coming from other CSRs (like mimpid, mip etc). SEC clean with CLIC==0 and CLIC==1. Signed-off-by: Oystein Knauserud <Oystein.Knauserud@silabs.com>
|
I will revert some of these changes: I will only use the csr_next_value function wherever csr_wdata_int is used, and not for the cases where already resolved next_values or constants are used. |
… not depent on csr_wdata_int. SEC clean. Signed-off-by: Oystein Knauserud <Oystein.Knauserud@silabs.com>
Silabs-ArjanB
approved these changes
Apr 24, 2023
rtl/cv32e40x_cs_registers.sv
Outdated
| mstatush_we = 1'b0; | ||
| mstatus_alias_we = 1'b0; | ||
|
|
||
| misa_n = misa_rdata; // Read only | ||
| misa_n = csr_next_value(misa_rdata, CSR_MISA_MASK, MISA_VALUE); // Read only |
There was a problem hiding this comment.
Introduce MISA_RESET_VAL (even though it will be the same as this value)
| .WIDTH (32), | ||
| .RESETVALUE (32'd0) | ||
| .WIDTH (32 ), | ||
| .MASK (IRQ_MASK ), |
There was a problem hiding this comment.
IRQ_MASK should be renamed as the others
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All CSR instances now use MASK and RESET_VAL. Some CSRs that are dependent on other CSR next values (mnxti, mscratchcsw[l]) do not use the function. Neither does the read-only CSRs that rely on inputs not coming from other CSRs (like mimpid, mip etc).
Should fix the remaining fixes for issue #766.
SEC clean with CLIC==0 and CLIC==1.