Rewrite KNXD to use Debian package during installation

[holgerfriedrich]

Installing optional component knxd fails on RPI3B+ with Buster.
This is probably an issue with upstream repos.

/bin/bash ../../libtool --tag=CXX --mode=link g++ -g -O2 -std=c++0x -Wno-subobject-linkage -o findknxusb findknxusb.o -lusb-1.0 -lev -lfmt libtool: link: g++ -g -O2 -std=c++0x -Wno-subobject-linkage -o findknxusb findknxusb.o -lusb-1.0 -lev -lfmt g++ -DHAVE_CONFIG_H -I. -I../.. -I../../src/libserver -I../../src/common -I/usr/include/libusb-1.0 -I/root/knxdbuild/fmt -g -O2 -std=c++0x -Wno-subobject-linkage -MT usb.o -MD -MP -MF .deps/usb.Tpo -c -o usb.o usb.cpp In file included from /usr/lib/gcc/arm-linux-gnueabihf/8/include-fixed/limits.h:194, from /usr/lib/gcc/arm-linux-gnueabihf/8/include-fixed/syslimits.h:7, from /usr/lib/gcc/arm-linux-gnueabihf/8/include-fixed/limits.h:34, from /usr/include/libusb-1.0/libusb.h:62, from usb.h:24, from usb.cpp:23: /root/knxdbuild/fmt/fmt/format.h: In member function ‘void fmt::internal::ArgFormatterBase::visit_char(int)’: /root/knxdbuild/fmt/fmt/format.h:1825:20: error: expected unqualified-id before numeric constant const unsigned CHAR_WIDTH = 1; ^~~~~~~~~~ [...few more warnings...] make[3]: *** [Makefile:501: usb.o] Error 1 make[3]: Leaving directory '/root/knxdbuild/knxd/src/usb' make[2]: *** [Makefile:394: all-recursive] Error 1 make[2]: Leaving directory '/root/knxdbuild/knxd/src' make[1]: *** [Makefile:442: all-recursive] Error 1 make[1]: Leaving directory '/root/knxdbuild/knxd' make: *** [Makefile:378: all] Error 2 Created symlink /etc/systemd/system/multi-user.target.wants/knxd.service → /lib/systemd/system/knxd.service. Created symlink /etc/systemd/system/network-online.target.wants/knxd.service → /lib/systemd/system/knxd.service. Removed /etc/systemd/system/multi-user.target.wants/hciuart.service. Please reboot your device! OK. Please restart your system now...

Actually this is a weird error caused by a name conflict between libfmt and glibc. Newer glibc includes define CHAR_WIDTH to 8, resulting in the code const unsigned 8 = 1.
See also fmtlib/fmt#616
This is fixed in libfmt 5.0.0, though the script we download is using tags/3.0.0.

The question is how to get a hotfix for openhabian in here, either patching the header file or switching to a newer tag.

[EliasGabrielsson]

• Fetch script used in current code, extract relevant configuration parts.
• Recreate template configurations as files in this repository.
• Use provided Debian package: https://packages.debian.org/buster/knxd.📦

[mstormi]

@holgerfriedrich please update us, is this still an issue with current openHABian ? Can we, should we move over to apt ?

[holgerfriedrich]

@mstormi Just had a look at the script we fetch from the external repo. Still maintained, but also changing some other settings like bluetooth. Checks for RPI3, but will probably miss RPI4.
Anyway, we should move over to deb package, if there is one. https://packages.debian.org/buster/knxd

I cannot properly do this as I do not use knxd and do not know specifics about the knxd library.

[mstormi]

@holgerfriedrich since you opened this issue do you still see a need to take action here ?
If no, please close.
If yes, would you be willing to jump in ? I wouldn't know who's capable of this if not you so would also close in that case as there's no point in carrying forward these sort of ghost issues.

[mstormi]

On https://michlstechblog.info/blog/raspberry-pi-eibknx-ip-gateway-and-router-with-knxd/#more-3759 the author says
"I agree with you that on debian systems the install-debian.sh script is the prefered way. I also give interested user the hint that knxd is already included in debian and that its no longer needed to compile it yourself."
I just checked yes knxd package is available and installs fine.

So we should move there. Can you replace the code with a package install? Nothing else, it's not our business to configure it and get it running.

[holgerfriedrich]

Let me summarize:

We have an implementation based on a script which is loaded from github. It compiles and installs current master of knxd and cares for udev rules which eases connection of the hardware interface. It depends on the script developer, especially when it comes to new hardware or other changes. Updates will not be installed. Installation is done using make install, no wrapper like checkinstall is used to build and install a package, so uninstall only possible manually. Though, it installs latest master version, typically newer than any package can do. It is known to be working, at least in the past.

Debian/Raspberry PI OS provides knxd package from the standard repo, Ubuntu does starting with 20.04. This would be the clean approach. However, it may be the case that for installs of openHABian on custom Linux systems the package is not available. As I don't want to offer two ways of installing knxd, so this solution would just point towards the official knxd manual in this case.

I have a better feeling to go with an official package here. I don't have hardware at hand to test.
@EliasGabrielsson @mstormi WDYT?

[holgerfriedrich]

btw: Hotfixes that we introduced to fix the build are obsolete and can be removed.

[mstormi]

I have a better feeling to go with an official package here.

So do I. Was my comment ambiguous ?

I don't have hardware at hand to test.

Neither do I nor any other maintainer. That's why I said anything beyond pure installation of the package is not our business hence this PR should be a matter of minutes only, shouldn't it.