-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Things List: Add multiple search, select all. Inbox: Go to newly approved Thing(s) #3020
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
#2714 Bundle Size — 10.98MiB (+0.02%).1118a42(current) vs 7ef5b6f main#2698(baseline) Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
|
Current #2714 |
Baseline #2698 |
|
---|---|---|
Initial JS | 1.9MiB |
1.9MiB |
Initial CSS | 577.21KiB |
577.21KiB |
Cache Invalidation | 18.04% |
17.51% |
Chunks | 227 |
227 |
Assets | 250 |
250 |
Modules | 2951 |
2951 |
Duplicate Modules | 154 |
154 |
Duplicate Code | 1.8% |
1.8% |
Packages | 98 |
98 |
Duplicate Packages | 2 |
2 |
Bundle size by type 1 change
1 regression
Current #2714 |
Baseline #2698 |
|
---|---|---|
JS | 9.19MiB (+0.03% ) |
9.19MiB |
CSS | 867.02KiB |
867.02KiB |
Fonts | 526.1KiB |
526.1KiB |
Media | 295.6KiB |
295.6KiB |
IMG | 140.74KiB |
140.74KiB |
HTML | 1.38KiB |
1.38KiB |
Other | 871B |
871B |
Bundle analysis report Branch jimtng:things-search Project dashboard
Generated by RelativeCI Documentation Report issue
7dae381
to
1254f2a
Compare
Perhaps to make it super flexible, offer two approve/OK buttons:
WDYT? |
Seems reasonable. I like having the option and having that option might be less disruptive to the workflow some people might be used to. |
OK I'll add that here. Switching to Draft, it'll be force-pushed until it's ready + reviewed |
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Changed and original post updated with new screenshots |
There are several changes wrapped up in this PR because they are somewhat interdependent.
Filtering/Searching + Selections
The Thing count is updated to reflect the number of matches found when performing search/filtering
When filtering, the invisible Things (i.e. Things that do not meet the filter criteria) will be deselected. Only Things within the filtered result can be selected and acted upon (Remove, Disable, Enable). So if you first selected all your things (e.g. 100 things) then perform search/filtering which result in 5 things, then the total selected Things will now be just 5, and when you hit Remove, only those 5 will be removed.
This is a change in behaviour. Originally, the selected Things remain despite the search/filtering, so whilst the user may see 5 Things checked on the list, they can be removing other Things.
Add
Select All
/Deselect All
. This also works in tandem with search/filter. When the filtered result shows only 5 Things, Select All will only select those 5 Things and not all the available Things on the system.Here's an example of a filtered result + selection:
Search for Multiple Things
OR
operator, e.g. searching forbroker1,broker2
results in showing Things that match eitherbroker1
orbroker2
combined into the result listPreload Things List search
Inbox approval
Single Thing Approval
Add as Thing
andAdd as Thing (with Custom ID)
are merged into justAdd as Thing
. The subsequent dialog will prompt for both the Thing ID and the Label in one dialog, removing multiple steps.Thing UID / ID validation is performed within the Add a Thing dialog, and the validation status displayed instantly under the Thing ID input
It also checks against full UID conflicts against existing Things
Here, the user is given two OK buttons.
OK -> Edit
will approve the Thing and redirect them to the Thing Details page for that ThingOK
will approve it and bring them back to the same page (Inbox)Multiple Things Approval
Approve
is clicked, the user will be redirected to theThings List
page, with pre-set filter to show all and only the approved Things.