-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Item Add: Navigate to the new Item once added #3010
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
#2694 Bundle Size — 10.98MiB (~+0.01%).c6574e2(current) vs e7d9b65 main#2689(baseline) Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
|
Current #2694 |
Baseline #2689 |
|
---|---|---|
Initial JS | 1.9MiB |
1.9MiB |
Initial CSS | 577.21KiB |
577.21KiB |
Cache Invalidation | 18.04% |
19.12% |
Chunks | 227 |
227 |
Assets | 250 |
250 |
Modules | 2950 |
2950 |
Duplicate Modules | 154 |
154 |
Duplicate Code | 1.8% |
1.8% |
Packages | 98 |
98 |
Duplicate Packages | 2 |
2 |
Bundle size by type 1 change
1 regression
Current #2694 |
Baseline #2689 |
|
---|---|---|
JS | 9.19MiB (~+0.01% ) |
9.19MiB |
CSS | 867.02KiB |
867.02KiB |
Fonts | 526.1KiB |
526.1KiB |
Media | 295.6KiB |
295.6KiB |
IMG | 140.74KiB |
140.74KiB |
HTML | 1.38KiB |
1.38KiB |
Other | 871B |
871B |
Bundle analysis report Branch jimtng:item-create-returnpage Project dashboard
Generated by RelativeCI Documentation Report issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable.
WDYT @ghys ?
Would it be worth requesting something similar for Things too, at least when creating a Thing manually (e.g. Generic MQTT Thing)? I find that even more annoying than the Item behavior, perhaps because I rarely create an Item like that. Maybe a separate issue should be opened for that. |
Good point, Rich 👍 |
Maybe open a separate issue..it will be in a different pr. Thanks |
This PR changes the navigation / where the user is sent to after creating/adding a new item.
Currently, if you go to Settings -> Items -> Add -> Save, you'll be brought back to the Items list (back navigation).
+
again to add another item. No problems.This PR changes this behavior so that after the new item is saved/added, the user is redirected to the Item Details page of that new item, so they can immediately work on it.
< Back
which will bring them to the Add Item page, so they can enter new details and create a new item.I think this workflow is more streamlined whether the user wants to add one item or multiple items.
This PR doesn't change the navigation behavior when editing an item. As previously done, the user would be sent back to the previous page, which would be the Item details. In other words: Settings -> Items (list) -> Item Details -> Edit -> Save -> Back to Item Details.